[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok The --ldap_passwords_in_clear_ok flag was originally intended to allow configurations where Impala connects to LDAP without SSL, for testing purposes. Since then, two other uses of the flag have been added: 1) for controlling whether cookies include the 'Secure' attribute and 2) for controlling whether the webserver allows LDAP auth to be enabled if SSL isn't. Some use cases may prefer to control these values separately, so this patch separates them into three different flags. Testing: - Updated existing tests that use --ldap_passwords_in_clear_ok Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Reviewed-on: http://gerrit.cloudera.org:8080/16829 Reviewed-by: Impala Public Jenkins Tested-by: Thomas Tauber-Marshall --- M be/src/rpc/authentication-util.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java 5 files changed, 19 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Thomas Tauber-Marshall: Verified -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: Verified+1 Failed again due to IMPALA-10398. Since everything else is passing and this is low-risk I'm going to go ahead and push it in -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 17 Dec 2020 01:55:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Thomas Tauber-Marshall has removed a vote on this change. Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6787/ -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 16 Dec 2020 22:47:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6787/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 16 Dec 2020 17:15:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: verify failed due to IMPALA-10398 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 16 Dec 2020 17:14:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6782/ -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 16 Dec 2020 03:00:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6782/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 Dec 2020 21:21:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 Dec 2020 21:21:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6775/ -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 Dec 2020 00:16:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7855/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 Dec 2020 23:17:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6775/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 Dec 2020 22:55:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 Dec 2020 22:55:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 3: Code-Review+2 carrying forward -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 Dec 2020 22:55:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16829 to look at the new patch set (#3). Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok The --ldap_passwords_in_clear_ok flag was originally intended to allow configurations where Impala connects to LDAP without SSL, for testing purposes. Since then, two other uses of the flag have been added: 1) for controlling whether cookies include the 'Secure' attribute and 2) for controlling whether the webserver allows LDAP auth to be enabled if SSL isn't. Some use cases may prefer to control these values separately, so this patch separates them into three different flags. Testing: - Updated existing tests that use --ldap_passwords_in_clear_ok Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 --- M be/src/rpc/authentication-util.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java 5 files changed, 19 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/16829/3 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6747/ -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 10 Dec 2020 03:22:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 09 Dec 2020 21:50:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6747/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 09 Dec 2020 21:50:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 1: I thought about whether we should try to keep the behaviour backward compatible, but it seems like that would be more confusing and complex. So this seems like the right way to do it. -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 09 Dec 2020 21:38:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 09 Dec 2020 21:39:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16829 ) Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7791/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 07 Dec 2020 23:56:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10381: Fix overloading of --ldap passwords in clear ok
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16829 Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok .. IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok The --ldap_passwords_in_clear_ok flag was originally intended to allow configurations where Impala connects to LDAP without SSL, for testing purposes. Since then, two other uses of the flag have been added: 1) for controlling whether cookies include the 'Secure' attribute and 2) for controlling whether the webserver allows LDAP auth to be enabled if SSL isn't. Some use cases may prefer to control these values separately, so this patch separates them into three different flags. Testing: - Updated existing tests that use --ldap_passwords_in_clear_ok Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 --- M be/src/rpc/authentication-util.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java 5 files changed, 17 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/16829/1 -- To view, visit http://gerrit.cloudera.org:8080/16829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83 Gerrit-Change-Number: 16829 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall
