[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 05 Feb 2021 11:22:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. IMPALA-10389: impala-profile-tool container Add a build step for an impala-profile-tool docker image that makes it easy to run the binary on any system. This container is automatically built as part of the docker build. This sets up a new build context that doesn't pull in all of the same dependencies or depend on the Java build Testing: cat logs/cluster/profiles/* | \ docker run -i impala_profile_tool I uploaded a build of the container to dockerhub too: timgarmstrong/impala_profile_tool Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Reviewed-on: http://gerrit.cloudera.org:8080/17015 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docker/CMakeLists.txt A docker/impala_profile_tool/Dockerfile M docker/setup_build_context.py A docker/utility_entrypoint.sh 4 files changed, 203 insertions(+), 46 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 05 Feb 2021 05:44:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6873/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 05 Feb 2021 05:44:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 2: Code-Review+2 This looks good to me -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 05 Feb 2021 01:36:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8079/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 05 Feb 2021 01:01:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/17015 )
Change subject: IMPALA-10389: impala-profile-tool container
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt
File docker/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@132
PS1, Line 132: file(WRITE ${CMAKE_SOURCE_DIR}/docker/docker-images.txt
"${exported_image_names}")
> I'm wondering whether it is significant that the profile tool image is adde
You're right, this should go at the end. I didn't check the contents of the
file.
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@172
PS1, Line 172: setup_utility_build_context.py
> I think this should be setup_build_context.py?
Done
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@184
PS1, Line 184: WORKING_DIRECTORY
${IMPALA_UTILITY_BUILD_CONTEXT_DIR}/${build_type}
> Nit: indentation should line up with COMMAND
Done
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@186
PS1, Line 186: #DEPENDS
${CMAKE_SOURCE_DIR}/bin/graceful_shutdown_backends.sh
> Nit: stray line?
Missing the entrypoint script.
--
To view, visit http://gerrit.cloudera.org:8080/17015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714
Gerrit-Change-Number: 17015
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Fri, 05 Feb 2021 00:39:36 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17015 to look at the new patch set (#2). Change subject: IMPALA-10389: impala-profile-tool container .. IMPALA-10389: impala-profile-tool container Add a build step for an impala-profile-tool docker image that makes it easy to run the binary on any system. This container is automatically built as part of the docker build. This sets up a new build context that doesn't pull in all of the same dependencies or depend on the Java build Testing: cat logs/cluster/profiles/* | \ docker run -i impala_profile_tool I uploaded a build of the container to dockerhub too: timgarmstrong/impala_profile_tool Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 --- M docker/CMakeLists.txt A docker/impala_profile_tool/Dockerfile M docker/setup_build_context.py A docker/utility_entrypoint.sh 4 files changed, 203 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17015/2 -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/17015 )
Change subject: IMPALA-10389: impala-profile-tool container
..
Patch Set 1:
(4 comments)
Overall, this makes sense to me.
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt
File docker/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@132
PS1, Line 132: file(WRITE ${CMAKE_SOURCE_DIR}/docker/docker-images.txt
"${exported_image_names}")
I'm wondering whether it is significant that the profile tool image is added
later in this file. What order does everything go in? Does docker-images.txt
contain the profile tool image?
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@172
PS1, Line 172: setup_utility_build_context.py
I think this should be setup_build_context.py?
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@184
PS1, Line 184: WORKING_DIRECTORY
${IMPALA_UTILITY_BUILD_CONTEXT_DIR}/${build_type}
Nit: indentation should line up with COMMAND
http://gerrit.cloudera.org:8080/#/c/17015/1/docker/CMakeLists.txt@186
PS1, Line 186: #DEPENDS
${CMAKE_SOURCE_DIR}/bin/graceful_shutdown_backends.sh
Nit: stray line?
--
To view, visit http://gerrit.cloudera.org:8080/17015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714
Gerrit-Change-Number: 17015
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Thu, 04 Feb 2021 19:32:54 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8061/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 02 Feb 2021 01:32:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17015 Change subject: IMPALA-10389: impala-profile-tool container .. IMPALA-10389: impala-profile-tool container Add a build step for an impala-profile-tool docker image that makes it easy to run the binary on any system. This container is automatically built as part of the docker build. This sets up a new build context that doesn't pull in all of the same dependencies or depend on the Java build Testing: cat logs/cluster/profiles/* | \ docker run -i impala_profile_tool I uploaded a build of the container to dockerhub too: timgarmstrong/impala_profile_tool Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 --- M docker/CMakeLists.txt A docker/impala_profile_tool/Dockerfile M docker/setup_build_context.py A docker/utility_entrypoint.sh 4 files changed, 200 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17015/1 -- To view, visit http://gerrit.cloudera.org:8080/17015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I36915cd686ab930dcc934bc0c81bff8c16d46714 Gerrit-Change-Number: 17015 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
