[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Mar 2021 22:59:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. IMPALA-10397: Fix test_single_workload The logs on failed runs indicated that the autoscaler never started another cluster. This can only happen if it never notices a queued query which is possible since this test was only failing in release builds. This patch increases the runtime of the sample query to make execution more predictable. Testing: Looped on my local on a release build Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Reviewed-on: http://gerrit.cloudera.org:8080/17218 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_auto_scaling.py 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7003/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Mar 2021 17:00:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Mar 2021 17:00:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Mar 2021 00:44:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8439/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Mar 2021 00:36:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17218/1/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/17218/1/tests/custom_cluster/test_auto_scaling.py@49 PS1, Line 49: # two comparisons and should take around 2 second to complete. > I think this will now be 2 seconds? Done -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Mar 2021 00:15:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Hello Andrew Sherman, Abhishek Rawat, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17218 to look at the new patch set (#2). Change subject: IMPALA-10397: Fix test_single_workload .. IMPALA-10397: Fix test_single_workload The logs on failed runs indicated that the autoscaler never started another cluster. This can only happen if it never notices a queued query which is possible since this test was only failing in release builds. This patch increases the runtime of the sample query to make execution more predictable. Testing: Looped on my local on a release build Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e --- M tests/custom_cluster/test_auto_scaling.py 1 file changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17218/2 -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 1: (1 comment) LGTM, does this comment need updating? http://gerrit.cloudera.org:8080/#/c/17218/1/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/17218/1/tests/custom_cluster/test_auto_scaling.py@49 PS1, Line 49: # two comparisons and should take around 1 second to complete. I think this will now be 2 seconds? -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Mar 2021 22:59:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8426/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 23 Mar 2021 20:13:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397: Fix test single workload
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17218 Change subject: IMPALA-10397: Fix test_single_workload .. IMPALA-10397: Fix test_single_workload The logs on failed runs indicated that the autoscaler never started another cluster. This can only happen if it never notices a queued query which is possible since this test was only failing in release builds. This patch increases the runtime of the sample query to make execution more predictable. Testing: Looped on my local on a release build Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e --- M tests/custom_cluster/test_auto_scaling.py 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17218/1 -- To view, visit http://gerrit.cloudera.org:8080/17218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide3c7fb4509ce9a797b4cbdd141b2a319b923d4e Gerrit-Change-Number: 17218 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
