[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Reviewed-on: http://gerrit.cloudera.org:8080/17101 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 26 Feb 2021 02:46:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6922/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 25 Feb 2021 21:05:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 25 Feb 2021 21:05:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 25 Feb 2021 21:04:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8234/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 25 Feb 2021 02:22:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17101/4/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17101/4/be/src/runtime/tmp-file-mgr.cc@1029 PS4, Line 1029: TmpFileRemote* tmp_file_r = new TmpFileRemote( > Why was this change made? Done -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 25 Feb 2021 02:04:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Yida Wu has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17101/5 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17101/4/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17101/4/be/src/runtime/tmp-file-mgr.cc@1029 PS4, Line 1029: shared_ptr tmp_file_remote(new TmpFileRemote( Why was this change made? Seems like its basically equivalent to the original code, except probably slightly less efficient since the shared_ptr is created and destroyed in the case where we hit one of the two errors below (which means we're doing two extra atomic operations unnecessarily). -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 25 Feb 2021 00:38:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 4: looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 24 Feb 2021 01:18:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8217/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 24 Feb 2021 00:51:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8216/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 24 Feb 2021 00:46:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17101 to look at the new patch set (#4). Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 10 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17101/4 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17101 to look at the new patch set (#3). Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 10 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17101/3 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8212/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 23 Feb 2021 23:51:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 12 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17101/2 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8192/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Feb 2021 14:45:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17101 Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build .. IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 12 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17101/1 -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu
