[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. IMPALA-10536: Fix saml2_callback_token_ttl's description The unit in the description of saml2_callback_token_ttl was "seconds", while its value is interpreted as milliseconds and the default 30 was way too low. Changing the description to mention milliseconds. Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Reviewed-on: http://gerrit.cloudera.org:8080/17107 Reviewed-by: Csaba Ringhofer Tested-by: Csaba Ringhofer --- M be/src/util/backend-gflag-util.cc M tests/custom_cluster/test_saml2_sso.py 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 23 Feb 2021 08:35:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Verified+1 Code-Review+2 Only an unrelated test failed, created https://issues.apache.org/jira/browse/IMPALA-10540 Giving +1 verified as I don't that running the tests once more is useful. -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 23 Feb 2021 08:34:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6910/ -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 23 Feb 2021 02:09:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6910/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Feb 2021 20:27:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Feb 2021 20:27:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Feb 2021 20:18:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8197/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Feb 2021 20:14:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17107 Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. IMPALA-10536: Fix saml2_callback_token_ttl's description The unit in the description of saml2_callback_token_ttl was "seconds", while its value is interpreted as milliseconds and the default 30 was way too low. Changing the description to mention milliseconds. Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 --- M be/src/util/backend-gflag-util.cc M tests/custom_cluster/test_saml2_sso.py 2 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/17107/1 -- To view, visit http://gerrit.cloudera.org:8080/17107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1057f0c5694883d1b1e14075876c780d6c942a8 Gerrit-Change-Number: 17107 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
