[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. IMPALA-10576: Add refresh authorization to make a test case less flaky We found that a test case run in test_grant_revoke_with_role() that is used to verify a requesting user does not possess the necessary privilege to perform the GRANT operation could fail since the expected AuthorizationException is not returned after the query. Since the privilege of GRANT was revoked immediately before this test case, we suspect the authorization-related metadata has not been updated. To make this test case less flaky, in this patch we add a REFRESH AUTHORIZATION after the query that revoked the GRANT privilege from the requesting user. Testing: - Verified that this patch passes the core tests in an ASAN build. Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf Reviewed-on: http://gerrit.cloudera.org:8080/17165 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf Gerrit-Change-Number: 17165 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8343/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf Gerrit-Change-Number: 17165 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 11 Mar 2021 17:10:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky
Fang-Yu Rao has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. IMPALA-10576: Add refresh authorization to make a test case less flaky We found that a test case run in test_grant_revoke_with_role() that is used to verify a requesting user does not possess the necessary privilege to perform the GRANT operation could fail since the expected AuthorizationException is not returned after the query. Since the privilege of GRANT was revoked immediately before this test case, we suspect the authorization-related metadata has not been updated. To make this test case less flaky, in this patch we add a REFRESH AUTHORIZATION after the query that revoked the GRANT privilege from the requesting user. Testing: - Verified that this patch passes the core tests in an ASAN build. Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf --- M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/17165/3 -- To view, visit http://gerrit.cloudera.org:8080/17165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf Gerrit-Change-Number: 17165 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8319/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf Gerrit-Change-Number: 17165 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 09 Mar 2021 17:50:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17165 Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. IMPALA-10576: Add refresh authorization to make a test case less flaky We found that a test case run in test_grant_revoke_with_role() that is used to verify a requesting user does not possess the necessary privilege to perform the GRANT operation could fail since the expected AuthorizationException is not returned after the query. Since the privilege of GRANT was revoked immediately before this test case, we suspect the authorization-related metadate has not been updated. To make this test case less flaky, in this patch we add a REFRESH AUTHORIZATION after the query that revoked the GRANT privilege from the requesting user. Testing: - Verified that this patch passes the core tests in an ASAN build. Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf --- M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/17165/1 -- To view, visit http://gerrit.cloudera.org:8080/17165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf Gerrit-Change-Number: 17165 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Quanlong Huang