[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17256 ) Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. IMPALA-10596: De-flake teardown in TestAdmissionControllerStress Currently if the threads running queries in TestAdmissionControllerStress hit an error, they close their client which ultimately closes the query that it was running. If teardown() runs after the client is closed, it tries to cancel the query that the thread was running and hits an exception trying to cancel an already closed query. This results in the pytest throws the exception encountered in teardown() instead of the original exception that caused the test to fail in the first place. This patch fixes this by removing the query handle from the thread if the client is closed. Testing: Simulated hitting an error condition in the main thread that initially triggered this condition. Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Reviewed-on: http://gerrit.cloudera.org:8080/17256 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_admission_controller.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17256 ) Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Thu, 01 Apr 2021 05:56:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17256 ) Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7037/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 23:58:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17256 ) Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 23:58:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17256 ) Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8482/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:15:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17256 ) Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:13:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17256 Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. IMPALA-10596: De-flake teardown in TestAdmissionControllerStress Currently if the threads running queries in TestAdmissionControllerStress hit an error, they close their client which ultimately closes the query that it was running. If teardown() runs after the client is closed, it tries to cancel the query that the thread was running and hits an exception trying to cancel an already closed query. This results in the pytest throws the exception encountered in teardown() instead of the original exception that caused the test to fail in the first place. This patch fixes this by removing the query handle from the thread if the client is closed. Testing: Simulated hitting an error condition in the main thread that initially triggered this condition. Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 --- M tests/custom_cluster/test_admission_controller.py 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/17256/1 -- To view, visit http://gerrit.cloudera.org:8080/17256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77 Gerrit-Change-Number: 17256 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
