[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 01 Apr 2021 00:14:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. IMPALA-10608 followup: Detect the virtualenv tarball version When rebasing from an older commit, the version change in virtualenv can cause there to be multiple virtualenv tarballs of different versions in the infra/python/deps directory. bootstrap_virtualenv.py currently doesn't handle this gracefully, because it is looking for all virtualenv*.tar.gz files and fails when it finds more than one. This changes bootstrap_virtualenv.py to get the virtualenv version from the requirements.txt file and only look for the tarball with that version. If it fails to get the version, it falls back to the old method. Testing: - Copied virtualenv-16.7.10.tar.gz to virtualenv-16.7.9.tar.gz and verified that bootstrap_virtualenv.py works Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Reviewed-on: http://gerrit.cloudera.org:8080/17249 Reviewed-by: Joe McDonnell Tested-by: Joe McDonnell --- M infra/python/bootstrap_virtualenv.py 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 3: Verified+1 The GVO on patch 2 passed and all the jobs for patch 3 are past the point where this could impact anything. Going ahead with this. -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 31 Mar 2021 22:33:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 31 Mar 2021 21:41:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7031/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 31 Mar 2021 18:27:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8477/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 31 Mar 2021 17:34:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 31 Mar 2021 17:13:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17249 to look at the new patch set (#3). Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. IMPALA-10608 followup: Detect the virtualenv tarball version When rebasing from an older commit, the version change in virtualenv can cause there to be multiple virtualenv tarballs of different versions in the infra/python/deps directory. bootstrap_virtualenv.py currently doesn't handle this gracefully, because it is looking for all virtualenv*.tar.gz files and fails when it finds more than one. This changes bootstrap_virtualenv.py to get the virtualenv version from the requirements.txt file and only look for the tarball with that version. If it fails to get the version, it falls back to the old method. Testing: - Copied virtualenv-16.7.10.tar.gz to virtualenv-16.7.9.tar.gz and verified that bootstrap_virtualenv.py works Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 --- M infra/python/bootstrap_virtualenv.py 1 file changed, 25 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/17249/3 -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py@87 PS2, Line 87: line[0] == '#': > the line could be stripped before doing this Good point, done http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py@107 PS2, Line 107: virtualenv_tarball = \ > nit: +2 indentation Done -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 31 Mar 2021 17:13:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py@87 PS2, Line 87: line[0] == '#': the line could be stripped before doing this http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py@107 PS2, Line 107: virtualenv_tarball = \ nit: +2 indentation -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 16:33:42 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7029/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 16:07:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8476/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 16:07:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 ) Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8475/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 16:03:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17249 to look at the new patch set (#2). Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. IMPALA-10608 followup: Detect the virtualenv tarball version When rebasing from an older commit, the version change in virtualenv can cause there to be multiple virtualenv tarballs of different versions in the infra/python/deps directory. bootstrap_virtualenv.py currently doesn't handle this gracefully, because it is looking for all virtualenv*.tar.gz files and fails when it finds more than one. This changes bootstrap_virtualenv.py to get the virtualenv version from the requirements.txt file and only look for the tarball with that version. If it fails to get the version, it falls back to the old method. Testing: - Copied virtualenv-16.7.10.tar.gz to virtualenv-16.7.9.tar.gz and verified that bootstrap_virtualenv.py works Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 --- M infra/python/bootstrap_virtualenv.py 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/17249/2 -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10608 followup: Detect the virtualenv tarball version
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17249 Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version .. IMPALA-10608 followup: Detect the virtualenv tarball version When rebasing from an older commit, the version change in virtualenv can cause there to be multiple virtualenv tarballs of different versions in the infra/python/deps directory. bootstrap_virtualenv.py currently doesn't handle this gracefully, because it is looking for all virtualenv*.tar.gz files and fails when it finds more than one. This changes bootstrap_virtualenv.py to get the virtualenv version from the requirements.txt file and only look for the tarball with that version. If it fails to get the version, it falls back to the old method. Testing: - Copied virtualenv-16.7.10.tar.gz to virtualenv-16.7.9.tar.gz and verified that bootstrap_virtualenv.py works Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 --- M infra/python/bootstrap_virtualenv.py 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/17249/1 -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
