[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 3: > > Patch Set 1: Code-Review+2 > > > > Should we have a "the minicluster starts" test in Jenkins that > runs on 20.04? > > Good point. Did you mean it in the context of GVO or postcommit? > In general, we should probably revisit the question of our runtime > platform for the precommit tests on public Jenkins (there was an > earlier discussion about migrating GVO & friends to Ubuntu 18.04) > as well as how we handle additional (supported) OS platforms. I'll > kick off a discussion on dev@, it is a better medium for a wider > discussion. I'm generally in favor of pre-commit tests, rather than post, if it doesn't slow down the end-to-end wall-clock time to commit. I like your idea of discussing in dev@. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Thu, 01 Apr 2021 14:30:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 3: > Patch Set 1: Code-Review+2 > > Should we have a "the minicluster starts" test in Jenkins that runs on 20.04? Good point. Did you mean it in the context of GVO or postcommit? In general, we should probably revisit the question of our runtime platform for the precommit tests on public Jenkins (there was an earlier discussion about migrating GVO & friends to Ubuntu 18.04) as well as how we handle additional (supported) OS platforms. I'll kick off a discussion on dev@, it is a better medium for a wider discussion. -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Wed, 31 Mar 2021 16:57:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 Impala started adding Ubuntu 20.04 support in various places. This patch extends bootstrap_config.sh for Ubuntu 20.04 coverage: 1. The runtime version check error message is updated to claim support for Ubuntu 20.04. 2. Kudu needs libtinfo.5.so on Ubuntu 20.04 for the minicluster binaries. bin/bootstrap_system.sh now installs it when running on Ubuntu 20.04. 3. The OpenJDK default version reset to JDK 8 is extended to Ubuntu 20.04. Tested by running the code using docker/test-with-docker.py using --base-image=ubuntu:20.04 and observing that Kudu was able to start in the minicluster. The test runs completed, but there were test failures, for which separate tickets will be filed. Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Reviewed-on: http://gerrit.cloudera.org:8080/17240 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/bootstrap_system.sh 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Wed, 31 Mar 2021 14:24:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Wed, 31 Mar 2021 08:42:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7027/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Wed, 31 Mar 2021 08:42:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 1: Code-Review+2 Should we have a "the minicluster starts" test in Jenkins that runs on 20.04? -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Tue, 30 Mar 2021 13:50:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8464/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Tue, 30 Mar 2021 11:57:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17240 Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 Impala started adding Ubuntu 20.04 support in various places. This patch extends bootstrap_config.sh for Ubuntu 20.04 coverage: 1. The runtime version check error message is updated to claim support for Ubuntu 20.04. 2. Kudu needs libtinfo.5.so on Ubuntu 20.04 for the minicluster binaries. bin/bootstrap_system.sh now installs it when running on Ubuntu 20.04. 3. The OpenJDK default version reset to JDK 8 is extended to Ubuntu 20.04. Tested by running the code using docker/test-with-docker.py using --base-image=ubuntu:20.04 and observing that Kudu was able to start in the minicluster. The test runs completed, but there were test failures, for which separate tickets will be filed. Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 --- M bin/bootstrap_system.sh 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/17240/1 -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal
