[Impala-ASF-CR] IMPALA-10632: Update the Theta sketch serialization interface
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17261 ) Change subject: IMPALA-10632: Update the Theta sketch serialization interface .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 3 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 07 Apr 2021 12:45:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10632: Update the Theta sketch serialization interface
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17261 ) Change subject: IMPALA-10632: Update the Theta sketch serialization interface .. IMPALA-10632: Update the Theta sketch serialization interface DataSketches 3.0.0 removes the serialization of Update Theta sketch, and uses Compact Theta sketch to serialize for backward compatibility. tests: -Ran the tests from tests/query_test/test_datasketches.py Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Reviewed-on: http://gerrit.cloudera.org:8080/17261 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/datasketches-common.cc M be/src/exprs/datasketches-functions-ir.cc 3 files changed, 48 insertions(+), 42 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10632: Update the Theta sketch serialization interface
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17261 ) Change subject: IMPALA-10632: Update the Theta sketch serialization interface .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7050/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 3 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 07 Apr 2021 07:00:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10632: Update the Theta sketch serialization interface
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17261 ) Change subject: IMPALA-10632: Update the Theta sketch serialization interface .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 3 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 07 Apr 2021 07:00:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10632: Update the Theta sketch serialization interface
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17261 ) Change subject: IMPALA-10632: Update the Theta sketch serialization interface .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 07 Apr 2021 07:00:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10632: Update the Theta sketch serialization interface
Hello Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17261 to look at the new patch set (#2). Change subject: IMPALA-10632: Update the Theta sketch serialization interface .. IMPALA-10632: Update the Theta sketch serialization interface DataSketches 3.0.0 removes the serialization of Update Theta sketch, and uses Compact Theta sketch to serialize for backward compatibility. tests: -Ran the tests from tests/query_test/test_datasketches.py Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/datasketches-common.cc M be/src/exprs/datasketches-functions-ir.cc 3 files changed, 48 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/17261/2 -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10632 Update the Theta sketch serialization interface
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17261 ) Change subject: IMPALA-10632 Update the Theta sketch serialization interface .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8491/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 15:47:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10632 Update the Theta sketch serialization interface
Fucun Chu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17261 Change subject: IMPALA-10632 Update the Theta sketch serialization interface .. IMPALA-10632 Update the Theta sketch serialization interface DataSketches 3.0.0 removes the serialization of Update Theta sketch, and uses Compact Theta sketch to serialize for backward compatibility. tests: -Ran the tests from tests/query_test/test_datasketches.py Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/datasketches-common.cc M be/src/exprs/datasketches-functions-ir.cc 3 files changed, 48 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/17261/1 -- To view, visit http://gerrit.cloudera.org:8080/17261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I80470863097a4836ee07fe44babaef0c852f3051 Gerrit-Change-Number: 17261 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
