[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 19 May 2021 05:52:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. IMPALA-10678: Support custom SASL protocol name in Kudu client This patch added configurable flag variable kudu_sasl_protocol_name, and call Kudu client API to set the SASL protocol name when creating Kudu client in the FE and BE. Upgraded toolchain to pull in new version of Kudu which provides new Java/C++ client APIs for setting the SASL protocol name. Testing: - Passed core run. Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Reviewed-on: http://gerrit.cloudera.org:8080/17442 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc M be/src/exec/kudu-util.cc M be/src/util/backend-gflag-util.cc M bin/impala-config.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java 7 files changed, 15 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 23:55:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7161/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 23:55:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7157/ -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 22:26:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7157/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 16:31:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 16:31:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8740/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 03:19:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 03:11:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 03:06:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 2: rebased to fix some merge conflicts. -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 18 May 2021 02:59:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. IMPALA-10678: Support custom SASL protocol name in Kudu client This patch added configurable flag variable kudu_sasl_protocol_name, and call Kudu client API to set the SASL protocol name when creating Kudu client in the FE and BE. Upgraded toolchain to pull in new version of Kudu which provides new Java/C++ client APIs for setting the SASL protocol name. Testing: - Passed core run. Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 --- M be/src/common/global-flags.cc M be/src/exec/kudu-util.cc M be/src/util/backend-gflag-util.cc M bin/impala-config.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java 7 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/17442/2 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 18 May 2021 01:39:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17442 ) Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8716/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 14 May 2021 04:59:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10678: Support custom SASL protocol name in Kudu client
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17442 Change subject: IMPALA-10678: Support custom SASL protocol name in Kudu client .. IMPALA-10678: Support custom SASL protocol name in Kudu client This patch added configurable flag variable kudu_sasl_protocol_name, and call Kudu client API to set the SASL protocol name when creating Kudu client in the FE and BE. Upgraded toolchain to pull in new version of Kudu which provides new Java/C++ client APIs for setting the SASL protocol name. Testing: - Passed core run. Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 --- M be/src/common/global-flags.cc M be/src/exec/kudu-util.cc M be/src/util/backend-gflag-util.cc M bin/impala-config.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java 7 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/17442/1 -- To view, visit http://gerrit.cloudera.org:8080/17442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0fb0b50f5e42e8a720564e51ad6c6185b51e3647 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou
