[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19132 Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. IMPALA-10715: test decimal min max filters failed in exhaustive run This patch disables the bloom filters in decimal min/max filter test so that some of the non-qualifying rows can be returned from the kudu scanners. The test specifically looks for these non-qualfying rows in the hash join node With the patch, the test passes in the exhaustive mode. Testing: - Unit test - Core test Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f --- M tests/query_test/test_runtime_filters.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/19132/1 -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11620/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 12 Oct 2022 17:34:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19132/1/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/19132/1/tests/query_test/test_runtime_filters.py@234 PS1, Line 234: self.execute_query("SET ENABLED_RUNTIME_FILTER_TYPES=MIN_MAX") Can we put this into the test vector like on for example L152? -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 13 Oct 2022 16:00:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. IMPALA-10715: test decimal min max filters failed in exhaustive run This patch enables only the min/max filters in decimal min/max filter test so that some of the non-qualifying rows can be returned from the kudu scanners. Previously, the tests allows bloom filters to filter out rows at the kudu scanner level which prevents non-qualfying rows to arrive at the hash join node. Such non-qualifying rows are required by the test. With the patch, the test passes in the exhaustive mode. The patch also refactors the above logic for the entire TestMinMaxFilters test so that each test case in it will only get the min/max filter. Testing: - Unit test - Core test Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f --- M tests/query_test/test_runtime_filters.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/19132/3 -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19132/1/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/19132/1/tests/query_test/test_runtime_filters.py@234 PS1, Line 234: if self.exploration_strategy() != 'exhaustive': > Can we put this into the test vector like on for example L152? Done -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 13 Oct 2022 18:26:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11629/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 13 Oct 2022 18:47:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 13 Oct 2022 18:46:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: Code-Review+2 LGTM! -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 13 Oct 2022 19:38:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8706/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 14 Oct 2022 16:28:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 14 Oct 2022 21:36:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8708/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 17 Oct 2022 09:23:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 17 Oct 2022 09:23:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 17 Oct 2022 14:24:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. IMPALA-10715: test decimal min max filters failed in exhaustive run This patch enables only the min/max filters in decimal min/max filter test so that some of the non-qualifying rows can be returned from the kudu scanners. Previously, the tests allows bloom filters to filter out rows at the kudu scanner level which prevents non-qualfying rows to arrive at the hash join node. Such non-qualifying rows are required by the test. With the patch, the test passes in the exhaustive mode. The patch also refactors the above logic for the entire TestMinMaxFilters test so that each test case in it will only get the min/max filter. Testing: - Unit test - Core test Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Reviewed-on: http://gerrit.cloudera.org:8080/19132 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/query_test/test_runtime_filters.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f Gerrit-Change-Number: 19132 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy