[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17599 )

Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..


Patch Set 3:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/8948/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 
Gerrit-Comment-Date: Fri, 18 Jun 2021 00:14:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17599 )

Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..


Patch Set 2:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/8947/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 
Gerrit-Comment-Date: Fri, 18 Jun 2021 00:11:40 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-17 Thread Anonymous Coward (Code Review)
Hello Yu-Wen Lai, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/17599

to look at the new patch set (#3).

Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..

IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn 
to table write id mapping

Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
A fe/src/main/java/org/apache/impala/catalog/TableWriteId.java
A fe/src/test/java/org/apache/impala/catalog/CatalogTableWriteIdTest.java
3 files changed, 187 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/17599/3
--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 


[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-17 Thread Anonymous Coward (Code Review)
Hello Yu-Wen Lai, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/17599

to look at the new patch set (#2).

Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..

IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn 
to table write id mapping

Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
A fe/src/main/java/org/apache/impala/catalog/TableWriteId.java
A fe/src/test/java/org/apache/impala/catalog/CatalogTableWriteIdTest.java
3 files changed, 187 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/17599/2
--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 


[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-16 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17599 )

Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17599/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java
File fe/src/main/java/org/apache/impala/catalog/Catalog.java:

http://gerrit.cloudera.org:8080/#/c/17599/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java@776
PS1, Line 776: (
nit: add white space


http://gerrit.cloudera.org:8080/#/c/17599/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java@779
PS1, Line 779:
nit: wrong indentation


http://gerrit.cloudera.org:8080/#/c/17599/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java@787
PS1, Line 787:
nit: white space should be removed


http://gerrit.cloudera.org:8080/#/c/17599/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java@789
PS1, Line 789: }
nit: redundant right curly bracket?



--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 
Gerrit-Comment-Date: Wed, 16 Jun 2021 23:57:59 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17599 )

Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..


Patch Set 1:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/8945/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 16 Jun 2021 22:09:28 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn to table write id mapping

2021-06-16 Thread Anonymous Coward (Code Review)
kis...@cloudera.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17599


Change subject: IMPALA-10751: new API in CatalogD to be used by Event processor 
for caching txn to table write id mapping
..

IMPALA-10751: new API in CatalogD to be used by Event processor for caching txn 
to table write id mapping

Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
A fe/src/main/java/org/apache/impala/catalog/TableWriteId.java
A fe/src/test/java/org/apache/impala/catalog/CatalogTableWriteIdTest.java
3 files changed, 188 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/17599/1
--
To view, visit http://gerrit.cloudera.org:8080/17599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2058fdf591b2655a10a92192d5f629b72a85f08a
Gerrit-Change-Number: 17599
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward