[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 3: @Csaba It would good to have a test case that verified this behavior -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 21:49:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Had started GVO but then noticed that a GVO had already succeeded. So instead will just submit the changes -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 19:59:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Bikramjeet Vig has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. IMPALA-10973: Do not schedule empty scan nodes to coordinator Until now fragments with scan nodes that have no scan ranges were scheduled to the coordinator, even if it is an exclusive coordinator. This could possibly lead to a lot of work to be scheduled to the coordinator. This patch changes the logic to choose a random executor instead. Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Reviewed-on: http://gerrit.cloudera.org:8080/17954 Tested-by: Impala Public Jenkins Reviewed-by: Abhishek Rawat Reviewed-by: Bikramjeet Vig --- M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h 2 files changed, 17 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Verified Abhishek Rawat: Looks good to me, but someone else must approve Bikramjeet Vig: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7547/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 19:58:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 19:57:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 19:40:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 19:26:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9624/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 13:29:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17954 Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. IMPALA-10973: Do not schedule empty scan nodes to coordinator Until now fragments with scan nodes that have no scan ranges were scheduled to the coordinator, even if it is an exclusive coordinator. This could possibly lead to a lot of work to be scheduled to the coordinator. This patch changes the logic to choose a random executor instead. Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef --- M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h 2 files changed, 17 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/17954/1 -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7545/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31df3861aad2e3e91cab621ff122a4f721905ef Gerrit-Change-Number: 17954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 19 Oct 2021 13:12:31 + Gerrit-HasComments: No
