[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header case-insensitive Updated THttpServer::parseHeader to treat 'X-Forwarded-For' header name as case-insensitive. Added fe test (LdapHS2Test) to use mixed case 'x-forwarded-for' header. Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Reviewed-on: http://gerrit.cloudera.org:8080/18048 Reviewed-by: Abhishek Rawat Tested-by: Impala Public Jenkins --- M be/src/transport/THttpServer.cpp M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 2 files changed, 22 insertions(+), 7 deletions(-) Approvals: Abhishek Rawat: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 16 Dec 2021 05:02:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9935/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 15 Dec 2021 22:49:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header case-insensitive Updated THttpServer::parseHeader to treat 'X-Forwarded-For' header name as case-insensitive. Added fe test (LdapHS2Test) to use mixed case 'x-forwarded-for' header. Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 --- M be/src/transport/THttpServer.cpp M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 2 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/18048/5 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 5: Code-Review+2 Carrying forward +2 after rebase -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 15 Dec 2021 22:27:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7705/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 15 Dec 2021 22:29:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 4: Looks like the pre-commit test is hitting IMPALA-10999 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Nov 2021 15:00:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7677/ -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Nov 2021 14:53:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Nov 2021 08:15:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7677/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Nov 2021 08:15:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7674/ -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Nov 2021 00:18:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 17:27:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7674/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 17:27:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7671/ -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 10:05:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7671/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 03:34:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 03:33:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9839/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 02:46:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18048/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/18048/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@396 PS1, Line 396: "X-Forwarded-For" > nit: maybe just add a separate simple test like Case2 above (mentioning tha Done -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 02:23:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header case-insensitive Updated THttpServer::parseHeader to treat 'X-Forwarded-For' header name as case-insensitive. Added fe test (LdapHS2Test) to use mixed case 'x-forwarded-for' header. Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 --- M be/src/transport/THttpServer.cpp M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 2 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/18048/2 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18048/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/18048/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@396 PS1, Line 396: "X-Forwarded-For" nit: maybe just add a separate simple test like Case2 above (mentioning that it checks specifically for case-insensitivity) to make it obvious what we are testing -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 23 Nov 2021 21:04:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9835/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 23 Nov 2021 04:45:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18048 Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header case-insensitive Updated THttpServer::parseHeader to treat 'X-Forwarded-For' header name as case-insensitive. Updated existing fe tests (LdapHS2Test) to use mixed case 'x-forwarded-for' header. Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 --- M be/src/transport/THttpServer.cpp M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/18048/1 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig
