[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. IMPALA-0: Switch debug builds to use -Og GCC's -Og applies optimizations that are compatible with being debuggable. It is similar to -O1 and results in a modest speed-up. This modifies the default debug build to use -Og, so it is now more akin to a fastdebug mode. Even though -Og is intended to preserve debuggability, optimization always impacts debuggability and -Og is no exception. To enable the old behavior, this adds a DEBUG_NOOPT build mode that retains the old non-optimized behavior. Using the -debug_noopt flag with buildall.sh enables this behavior. Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Reviewed-on: http://gerrit.cloudera.org:8080/18200 Tested-by: Impala Public Jenkins Reviewed-by: Laszlo Gaal (Cloudera) Reviewed-by: Csaba Ringhofer --- M be/CMakeLists.txt M buildall.sh 2 files changed, 28 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Laszlo Gaal (Cloudera): Looks good to me, but someone else must approve Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal (Cloudera) Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal (Cloudera) Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 18 Mar 2022 10:31:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 5: Code-Review+1 (1 comment) LGTM, letting others take a look as well. http://gerrit.cloudera.org:8080/#/c/18200/5/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18200/5/be/CMakeLists.txt@69 PS5, Line 69: (currently only ASAN) Nit (and completely beside the point, just spotted it): this can now be removed I think. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 16 Mar 2022 15:32:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 10 Mar 2022 04:14:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7921/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 09 Mar 2022 23:39:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7861/ -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 23 Feb 2022 02:22:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7861/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:47:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10204/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:41:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10203/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:41:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 4: Build Successful https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10200/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:37:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10202/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:36:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 3: Build Successful https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10199/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:34:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 2: Build Successful https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10198/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:34:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18200/3/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/18200/3/buildall.sh@233 PS3, Line 233: echo "[-debug_noopt] : Debug build without optimizations applied. The regular debug"\ > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 22 Feb 2022 19:17:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18200 to look at the new patch set (#4). Change subject: IMPALA-0: Switch debug builds to use -Og .. IMPALA-0: Switch debug builds to use -Og GCC's -Og applies optimizations that are compatible with being debuggable. It is similar to -O1 and results in a modest speed-up. This modifies the default debug build to use -Og, so it is now more akin to a fastdebug mode. Even though -Og is intended to preserve debuggability, optimization always impacts debuggability and -Og is no exception. To enable the old behavior, this adds a DEBUG_NOOPT build mode that retains the old non-optimized behavior. Using the -debug_noopt flag with buildall.sh enables this behavior. Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e --- M be/CMakeLists.txt M buildall.sh 2 files changed, 28 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/18200/4 -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18200/3/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/18200/3/buildall.sh@233 PS3, Line 233: echo "[-debug_noopt] : Debug build without optimizations applied. The regular debug"\ line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 22 Feb 2022 19:16:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18200 to look at the new patch set (#3). Change subject: IMPALA-0: Switch debug builds to use -Og .. IMPALA-0: Switch debug builds to use -Og GCC's -Og applies optimizations that are compatible with being debuggable. It is similar to -O1 and results in a modest speed-up. This modifies the default debug build to use -Og, so it is now more akin to a fastdebug mode. Even though -Og is intended to preserve debuggability, optimization always impacts debuggability and -Og is no exception. To enable the old behavior, this adds a DEBUG_NOOPT build mode that retains the old non-optimized behavior. Using the -debug_noopt flag with buildall.sh enables this behavior. Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e --- M be/CMakeLists.txt M buildall.sh 2 files changed, 28 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/18200/3 -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18200/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/18200/2/buildall.sh@233 PS2, Line 233: echo "[-debug_noopt] : Debug build without optimizations applied. The regular debug"\ line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 22 Feb 2022 19:13:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18200 to look at the new patch set (#2). Change subject: IMPALA-0: Switch debug builds to use -Og .. IMPALA-0: Switch debug builds to use -Og GCC's -Og applies optimizations that are compatible with being debuggable. It is similar to -O1 and results in a modest speed-up. This modifies the default debug build to use -Og, so it is now more akin to a fastdebug mode. Even though -Og is intended to preserve debuggability, optimization always impacts debuggability and -Og is no exception. To enable the old behavior, this adds a DEBUG_NOOPT build mode that retains the old non-optimized behavior. Using the -debug_noopt flag with buildall.sh enables this behavior. Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e --- M be/CMakeLists.txt M buildall.sh 2 files changed, 29 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/18200/2 -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
