[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18250 Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail This patch addresses the potential row count over-estimation against HBase tables by capping the estimation by the row count when available from HMS. Testing: 1. PlannerTest.testResourceRequirements passes with an update on the cardinality of the HBase tables involved. 2. Core test [TBD] Change-Id: I11c51f76212e1337a7e726097931890c2edab182 --- M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/joins.test 2 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/18250/2 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail This patch addresses the potential row count over-estimation against HBase tables by capping the estimation by the row count when available from HMS. Testing: 1. PlannerTest.testResourceRequirements passes with an update on the cardinality of the HBase tables involved. 2. Core test [TBD] Change-Id: I11c51f76212e1337a7e726097931890c2edab182 --- M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/joins.test 2 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/18250/3 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 17 Feb 2022 23:00:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10180/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 17 Feb 2022 23:09:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail This patch addresses the potential row count over-estimation against HBase tables by capping the estimation by the row count when available from HMS. Testing: 1. Core test [TBD] Change-Id: I11c51f76212e1337a7e726097931890c2edab182 --- M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/18250/4 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 4: Build Successful https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10194/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 22 Feb 2022 15:39:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10198/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 22 Feb 2022 15:40:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 4: Code-Review+2 (1 comment) Thanks for digging into this! http://gerrit.cloudera.org:8080/#/c/18250/4/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/18250/4/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@322 PS4, Line 322: rows_from_HMS nit: rowsFromHms. We use CamelCase in FE codes. -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 02:22:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail This patch addresses the potential row count over-estimation against HBase tables by capping the estimation by the row count when available from HMS. Testing: 1. ran core test successfully Change-Id: I11c51f76212e1337a7e726097931890c2edab182 --- M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/18250/5 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 5: (1 comment) Thanks Quanlong for the quick review! http://gerrit.cloudera.org:8080/#/c/18250/4/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/18250/4/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@322 PS4, Line 322: rowsFromHms = > nit: rowsFromHms. We use CamelCase in FE codes. Done -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 14:44:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10213/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 15:08:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 23:44:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 23:44:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7873/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 23:44:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 24 Feb 2022 06:24:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18250 ) Change subject: IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail .. IMPALA-11132 Front-end test PlannerTest.testResourceRequirements can fail This patch addresses the potential row count over-estimation against HBase tables by capping the estimation by the row count when available from HMS. Testing: 1. ran core test successfully Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Reviewed-on: http://gerrit.cloudera.org:8080/18250 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I11c51f76212e1337a7e726097931890c2edab182 Gerrit-Change-Number: 18250 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
