[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 20:09:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. IMPALA-11137: Enable proleptic Gregorian Calendar for Hive Since HIVE-22589, Hive still uses Julian Calendar for writing dates before 1582-10-15, whereas Impala uses proleptic Gregorian Calendar. This affects the results Impala gets when querying tables written by Hive. Currently, the Avro and ORC formats of date_tbl are suffering this issue. This patch enables proleptic Gregorian Calendar for Hive by default. It also reverts the two commits of IMPALA-9555 which modifies the tests to satisfy the inconsistent results. Tests: - Ran CORE tests Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Reviewed-on: http://gerrit.cloudera.org:8080/18262 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/resources/hive-site.xml.py M testdata/workloads/functional-query/queries/QueryTest/avro_date.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M tests/query_test/test_date_queries.py 4 files changed, 36 insertions(+), 38 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 13:40:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 1: Thank Csaba! -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 13:39:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7867/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 13:40:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 10:43:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10205/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Feb 2022 00:05:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/10194/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 22 Feb 2022 01:40:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18262 ) Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/10190/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 22 Feb 2022 01:38:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11137: Enable proleptic Gregorian Calendar for Hive
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18262 Change subject: IMPALA-11137: Enable proleptic Gregorian Calendar for Hive .. IMPALA-11137: Enable proleptic Gregorian Calendar for Hive Since HIVE-22589, Hive still uses Julian Calendar for writing dates before 1582-10-15, whereas Impala uses proleptic Gregorian Calendar. This affects the results Impala gets when querying tables written by Hive. Currently, the Avro and ORC formats of date_tbl are suffering this issue. This patch enables proleptic Gregorian Calendar for Hive by default. It also reverts the two commits of IMPALA-9555 which modifies the tests to satisfy the inconsistent results. Tests: - Ran CORE tests Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 --- M fe/src/test/resources/hive-site.xml.py M testdata/workloads/functional-query/queries/QueryTest/avro_date.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M tests/query_test/test_date_queries.py 4 files changed, 36 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/18262/1 -- To view, visit http://gerrit.cloudera.org:8080/18262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6be9c9720dd352d6821cdaa6c64d35ba20473bc0 Gerrit-Change-Number: 18262 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
