[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Thu, 12 May 2022 12:37:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables We currently don't implement correct behavior for CREATE TABLE LIKE statements for Iceberg tables. Neither on the source, nor on the target table side. This patch forbids such statements until they are correctly implemented. Testing * added e2e test Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Reviewed-on: http://gerrit.cloudera.org:8080/18517 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate
[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8096/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Thu, 12 May 2022 08:14:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Thu, 12 May 2022 08:14:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. Patch Set 1: Code-Review+2 Thanks for the fix Zoltan, LGTM! -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Thu, 12 May 2022 08:00:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10559/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Wed, 11 May 2022 16:13:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18517 Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables We currently don't implement correct behavior for CREATE TABLE LIKE statements for Iceberg tables. Neither on the source, nor on the target table side. This patch forbids such statements until they are correctly implemented. Testing * added e2e test Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/18517/1 -- To view, visit http://gerrit.cloudera.org:8080/18517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9cee6fc82547dabf63937cc541163c1ee59a4013 Gerrit-Change-Number: 18517 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
