[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. IMPALA-11495: Add glibc version and effective locale to the Web UI Added a new section "Other Info" in root page for WebUI, displaying effective locale and glibc version. Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Reviewed-on: http://gerrit.cloudera.org:8080/21252 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/util/default-path-handlers.cc M tests/webserver/test_web_pages.py M www/root.tmpl 3 files changed, 17 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 16 Apr 2024 14:09:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 16 Apr 2024 09:06:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10545/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 16 Apr 2024 09:06:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 3: Code-Review+2 Thanks for adding these useful info! -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 16 Apr 2024 09:05:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15907/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 16 Apr 2024 08:23:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Saurabh Katiyal has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. IMPALA-11495: Add glibc version and effective locale to the Web UI Added a new section "Other Info" in root page for WebUI, displaying effective locale and glibc version. Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 --- M be/src/util/default-path-handlers.cc M tests/webserver/test_web_pages.py M www/root.tmpl 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/21252/3 -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21252/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21252/2//COMMIT_MSG@9 PS2, Line 9: catalog, : coordinator and statestore nit: It sounds like executors don't have this. We can just remove this list. -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 16 Apr 2024 04:53:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15875/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Thu, 11 Apr 2024 16:11:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Saurabh Katiyal has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. IMPALA-11495: Add glibc version and effective locale to the Web UI Added a new section "Other Info" in root page for WebUI of catalog, coordinator and statestore displaying effective locale and glibc version. Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 --- M be/src/util/default-path-handlers.cc M tests/webserver/test_web_pages.py M www/root.tmpl 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/21252/2 -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 1: LGTM. Could you add some tests, e.g. in tests/webserver/test_web_pages.py? -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 10 Apr 2024 00:16:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21252 ) Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15796/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 07 Apr 2024 12:12:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11495: Add glibc version and effective locale to the Web UI
Saurabh Katiyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21252 Change subject: IMPALA-11495: Add glibc version and effective locale to the Web UI .. IMPALA-11495: Add glibc version and effective locale to the Web UI Added a new section "Other Info" in root page for WebUI of catalog, coordinator and statestore displaying effective locale and glibc version. Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 --- M be/src/util/default-path-handlers.cc M www/root.tmpl 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/21252/1 -- To view, visit http://gerrit.cloudera.org:8080/21252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia69c4d63df4beae29f5261691a8dcdd04b931de7 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Katiyal
