[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies

2022-11-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18994 )

Change subject: IMPALA-11627: Build Impala with cdw dependencies
..


Patch Set 6:

Thanks for the comment!
I am postponing this change as https://gerrit.cloudera.org/#/c/19149/ was 
merged and it bumps to a version of CDP that already contains the Hive changes 
I need. I still think that it will be useful to bump to a mixed cdp/cdw 
dependency in the future, but it is no longer urgent.


--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 04 Nov 2022 13:13:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies

2022-09-29 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18994 )

Change subject: IMPALA-11627: Build Impala with cdw dependencies
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18994/6/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/18994/6/java/pom.xml@109
PS6, Line 109:
nit: wrong indentation?



--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Yu-Wen Lai 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 29 Sep 2022 23:03:25 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies

2022-09-29 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/18994

to look at the new patch set (#6).

Change subject: IMPALA-11627: Build Impala with cdw dependencies
..

IMPALA-11627: Build Impala with cdw dependencies

The change switches to download cdw versions of Hive dependencies.
As cdw depends on older versions of some components than cdp,
this is a step back from some components, but this didn't lead
to test failures.

For maven artifects both cdp and cdw versions are downloaded
and added as repositiories, so all component can find the
versions it depends on.

Other changes:
- updated resource-requirements.test due to different number
  of files tpch_orc_def.lineitem
- added redirections/implementations for new HMS APIs in
  MetastoreService
- fixes the bug mentioned in IMPALA-11397

Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
---
M bin/impala-config.sh
M bin/jenkins/archive_m2_directory.sh
M fe/pom.xml
M 
fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java
M 
fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M java/pom.xml
M 
testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
8 files changed, 249 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18994/6
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins