[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 03 Nov 2022 00:52:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..

IMPALA-11682: Add tests for minor compacted insert only ACID tables

Only test changes. Minor compacted delta dirs are supported in
Impala since IMPALA-9512, but at that time Hive supported minor
compaction only on full ACID tables. Since that time Hive added
support for minor compacting insert only/MM tables (HIVE-22610).

Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Reviewed-on: http://gerrit.cloudera.org:8080/19164
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/acid.test
4 files changed, 92 insertions(+), 11 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11776/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 02 Nov 2022 20:04:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 5: Code-Review+2

Fixed the test, passing +2 from Zoltan


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 02 Nov 2022 19:44:30 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19164

to look at the new patch set (#5).

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..

IMPALA-11682: Add tests for minor compacted insert only ACID tables

Only test changes. Minor compacted delta dirs are supported in
Impala since IMPALA-9512, but at that time Hive supported minor
compaction only on full ACID tables. Since that time Hive added
support for minor compacting insert only/MM tables (HIVE-22610).

Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
---
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/acid.test
4 files changed, 92 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19164/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8770/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 02 Nov 2022 19:45:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 02 Nov 2022 19:45:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8747/


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 27 Oct 2022 18:48:09 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11723/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 27 Oct 2022 13:54:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-27 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19164

to look at the new patch set (#4).

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..

IMPALA-11682: Add tests for minor compacted insert only ACID tables

Only test changes. Minor compacted delta dirs are supported in
Impala since IMPALA-9512, but at that time Hive supported minor
compaction only on full ACID tables. Since that time Hive added
support for minor compacting insert only/MM tables (HIVE-22610).

Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
---
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/acid.test
4 files changed, 92 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19164/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8747/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 27 Oct 2022 13:33:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8742/


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:53:56 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11714/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 26 Oct 2022 11:51:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 2:

(1 comment)

Added a test table that was both major and then minor compacted and moved the 
new test tables to the end of the files.

http://gerrit.cloudera.org:8080/#/c/19164/1/testdata/workloads/functional-query/queries/QueryTest/acid.test
File testdata/workloads/functional-query/queries/QueryTest/acid.test:

http://gerrit.cloudera.org:8080/#/c/19164/1/testdata/workloads/functional-query/queries/QueryTest/acid.test@140
PS1, Line 140: tha
> nit: not needed 'the', or maybe use 'that'?
Done



--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 26 Oct 2022 11:31:21 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-26 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19164

to look at the new patch set (#2).

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..

IMPALA-11682: Add tests for minor compacted insert only ACID tables

Only test changes. Minor compacted delta dirs are supported in
Impala since IMPALA-9512, but at that time Hive supported minor
compaction only on full ACID tables. Since that time Hive added
support for minor compacting insert only/MM tables (HIVE-22610).

Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
---
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/acid.test
4 files changed, 91 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19164/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8742/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 26 Oct 2022 11:32:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 1: Code-Review+2

(1 comment)

Thanks for adding these tests!

http://gerrit.cloudera.org:8080/#/c/19164/1/testdata/workloads/functional-query/queries/QueryTest/acid.test
File testdata/workloads/functional-query/queries/QueryTest/acid.test:

http://gerrit.cloudera.org:8080/#/c/19164/1/testdata/workloads/functional-query/queries/QueryTest/acid.test@140
PS1, Line 140: the
nit: not needed 'the', or maybe use 'that'?



--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 25 Oct 2022 12:40:38 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19164 )

Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11693/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 24 Oct 2022 18:42:58 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19164


Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID 
tables
..

IMPALA-11682: Add tests for minor compacted insert only ACID tables

Only test changes. Minor compacted delta dirs are supported in
Impala since IMPALA-9512, but at that time Hive supported minor
compaction only on full ACID tables. Since that time Hive added
support for minor compacting insert only/MM tables (HIVE-22610).

Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
---
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/acid.test
4 files changed, 57 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19164/1
--
To view, visit http://gerrit.cloudera.org:8080/19164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7159283f3658f2119d38bd3393729535edd0a76f
Gerrit-Change-Number: 19164
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer