[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-04-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19624 )

Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Sai Hemanth Gantasala 
Gerrit-Comment-Date: Fri, 21 Apr 2023 05:51:45 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-04-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19624 )

Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..

IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event
processing by skipping unnecessary events

IMPALA-11822 introduced a new argument 'lastRefreshEventId' to the
HdfsPartition constructor and this is causing Hive builds to fail.
This addendum patch addresses this issue by keeping the old constructor
in the HdfsPartition class and call the new constructor with -1L as
default value for 'lastRefreshEventId'.

Testing: Verified that the Hive builds are passing with this patch.

Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Reviewed-on: http://gerrit.cloudera.org:8080/19624
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Sai Hemanth Gantasala 


[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-04-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19624 )

Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9241/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Sai Hemanth Gantasala 
Gerrit-Comment-Date: Fri, 21 Apr 2023 00:33:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-04-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19624 )

Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Sai Hemanth Gantasala 
Gerrit-Comment-Date: Fri, 21 Apr 2023 00:33:56 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-03-16 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19624 )

Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..


Patch Set 1: Code-Review+2

This seems like a good general principal if we want function-level stability.


--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Sai Hemanth Gantasala 
Gerrit-Comment-Date: Thu, 16 Mar 2023 17:10:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19624 )

Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/12630/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Sai Hemanth Gantasala 
Gerrit-Comment-Date: Thu, 16 Mar 2023 03:40:39 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event processing by skipping unnecessary events

2023-03-15 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19624


Change subject: IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event 
processing by skipping unnecessary events
..

IMPALA-11822: (Addendum) Optimize the Refresh/Invalidate event
processing by skipping unnecessary events

IMPALA-11822 introduced a new argument 'lastRefreshEventId' to the
HdfsPartition constructor and this is causing Hive builds to fail.
This addendum patch addresses this issue by keeping the old constructor
in the HdfsPartition class and call the new constructor with -1L as
default value for 'lastRefreshEventId'.

Testing: Verified that the Hive builds are passing with this patch.

Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
1 file changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/19624/1
--
To view, visit http://gerrit.cloudera.org:8080/19624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I803c13b58e3de047c12f75a584232819c7dc74c1
Gerrit-Change-Number: 19624
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala