[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. IMPALA-12110: Create Kudu table in CTAS without specifying primary key IMPALA-11809 adds support non unique primary key for Kudu table. It allows to create Kudu table without specifying primary key since partition columns could be promoted as non unique primary key. But when creating Kudu table in CTAS without specifying primary key, Impala returns parsing error. This patch fixed the parsing issue for creating Kudu table in CTAS without specifying primary key. Testing: - Added new test cases in parsing unit-test and end-to-end unit-test. - Passed core tests. Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Reviewed-on: http://gerrit.cloudera.org:8080/19825 Reviewed-by: Abhishek Chennaka Reviewed-by: Riza Suminto Tested-by: Impala Public Jenkins --- M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 3 files changed, 44 insertions(+), 2 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, but someone else must approve Riza Suminto: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 02 May 2023 02:47:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Thanks Riza and Abhishek for your review. -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 21:32:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9270/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 21:33:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Code-Review+2 Test coverage looks OK to me. -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 21:29:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 21:12:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 17:01:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12899/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 00:33:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12898/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 00:20:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19825/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/19825/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3319 PS1, Line 3319: "(PARTITION 1 < VALUES < 10, PARTITION 10 <= VALUES < 20, " + > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 01 May 2023 00:11:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. IMPALA-12110: Create Kudu table in CTAS without specifying primary key IMPALA-11809 adds support non unique primary key for Kudu table. It allows to create Kudu table without specifying primary key since partition columns could be promoted as non unique primary key. But when creating Kudu table in CTAS without specifying primary key, Impala returns parsing error. This patch fixed the parsing issue for creating Kudu table in CTAS without specifying primary key. Testing: - Added new test cases in parsing unit-test and end-to-end unit-test. - Passed core tests. Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 --- M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 3 files changed, 44 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/19825/2 -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19825/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/19825/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3319 PS1, Line 3319: "(PARTITION 1 < VALUES < 10, PARTITION 10 <= VALUES < 20, PARTITION VALUE = 30) " + line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 01 May 2023 00:00:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19825 Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. IMPALA-12110: Create Kudu table in CTAS without specifying primary key IMPALA-11809 adds support non unique primary key for Kudu table. It allows to create Kudu table without specifying primary key since partition columns could be promoted as non unique primary key. But when creating Kudu table in CTAS without specifying primary key, Impala returns parsing error. This patch fixed the parsing issue for creating Kudu table in CTAS without specifying primary key. Testing: - Added new test cases in parsing unit-test and end-to-end unit-test. - Passed core tests. Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 --- M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 3 files changed, 43 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/19825/1 -- To view, visit http://gerrit.cloudera.org:8080/19825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7bb0cf1954e0a4c3d864a800e929a88de272dd5 Gerrit-Change-Number: 19825 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou
