[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. IMPALA-12274: Fix memory leak from unreleased local reference In the constructor of the catalog class, after converting the catalog object created by NewObject to a global reference, the local reference was forgotten to be released, resulting in a minor memory leak. The solution is to use JniLocalFrame to automatically manage the local reference, ensuring proper memory management. Testing: manually test Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Reviewed-on: http://gerrit.cloudera.org:8080/20175 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/catalog/catalog.cc M be/src/catalog/catalog.h 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 9 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 8 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong Gerrit-Comment-Date: Wed, 23 Aug 2023 11:58:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 7 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong Gerrit-Comment-Date: Wed, 23 Aug 2023 07:39:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9625/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 8 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong Gerrit-Comment-Date: Wed, 23 Aug 2023 07:40:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 8 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong Gerrit-Comment-Date: Wed, 23 Aug 2023 07:40:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 7 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong Gerrit-Comment-Date: Mon, 21 Aug 2023 16:36:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13786/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 7 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong Gerrit-Comment-Date: Mon, 21 Aug 2023 03:18:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference
zhangqianqiong has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. IMPALA-12274: Fix memory leak from unreleased local reference In the constructor of the catalog class, after converting the catalog object created by NewObject to a global reference, the local reference was forgotten to be released, resulting in a minor memory leak. The solution is to use JniLocalFrame to automatically manage the local reference, ensuring proper memory management. Testing: manually test Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 --- M be/src/catalog/catalog.cc M be/src/catalog/catalog.h 2 files changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/20175/7 -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 7 Gerrit-Owner: zhangqianqiong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: zhangqianqiong
