[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock Previous to this patch we tried to load table iceberg_lineitem_multiblock with HDFS block size 524288. This failed in builds that use HDFS erasure coding which requires block size at least 1048576. This patch increases the block size to 1048576. This also triggers the bug that was fixed by IMPALA-12327. But to have more tests with multiblock tables this patch also adds table iceberg_lineitem_sixblocks and few tests with different MT_DOP settings. Testing: * tested in build with HDFS EC Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Reviewed-on: http://gerrit.cloudera.org:8080/20359 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test 3 files changed, 50 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Mon, 21 Aug 2023 20:53:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9609/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Mon, 21 Aug 2023 16:27:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9608/ -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Mon, 21 Aug 2023 16:24:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9608/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Mon, 21 Aug 2023 12:07:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Mon, 21 Aug 2023 12:07:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Mon, 21 Aug 2023 12:00:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Fri, 18 Aug 2023 10:14:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13746/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 15 Aug 2023 09:28:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20359 Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock Previous to this patch we tried to load table iceberg_lineitem_multiblock with HDFS block size 524288. This failed in builds that use HDFS erasure coding which requires block size at least 1048576. This patch increases the block size to 1048576. This also triggers the bug that was fixed by IMPALA-12327. But to have more tests with multiblock tables this patch also adds table iceberg_lineitem_sixblocks and few tests with different MT_DOP settings. Testing: * tested in build with HDFS EC Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 --- M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test 3 files changed, 50 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20359/1 -- To view, visit http://gerrit.cloudera.org:8080/20359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iad15a335407c12578eb822bb1cb4450647502e50 Gerrit-Change-Number: 20359 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
