[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-11 Thread Michael Smith (Code Review) 
Michael Smith has abandoned this change. ( 
http://gerrit.cloudera.org:8080/20467 )

Change subject: IMPALA-12402: v1 change the term from consistency to 
concurrency and fix nits
..


Abandoned

Merge into parent commit.
--
To view, visit http://gerrit.cloudera.org:8080/20467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I700a486aa3c1ff5ef27f2db636a59cb404ddbb8e
Gerrit-Change-Number: 20467
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-08 Thread Michael Smith (Code Review) 
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20467 )

Change subject: IMPALA-12402: v1 change the term from consistency to 
concurrency and fix nits
..


Patch Set 1:

Please add this to the original patch rather than adding an additional commit. 
Gerrit allows reviewing each revision, so we can see what specifically changes 
each time.

There's no mechanism to squash, and generally we prefer a single commit for a 
ticket.


--
To view, visit http://gerrit.cloudera.org:8080/20467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I700a486aa3c1ff5ef27f2db636a59cb404ddbb8e
Gerrit-Change-Number: 20467
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Fri, 08 Sep 2023 17:24:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20467 )

Change subject: IMPALA-12402: v1 change the term from consistency to 
concurrency and fix nits
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/13951/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/20467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I700a486aa3c1ff5ef27f2db636a59cb404ddbb8e
Gerrit-Change-Number: 20467
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 08 Sep 2023 05:02:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-07 Thread Anonymous Coward (Code Review) 
cclive1...@gmail.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/20467


Change subject: IMPALA-12402: v1 change the term from consistency to 
concurrency and fix nits
..

IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

Change-Id: I700a486aa3c1ff5ef27f2db636a59cb404ddbb8e
---
M be/src/runtime/exec-env.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
4 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/20467/1
--
To view, visit http://gerrit.cloudera.org:8080/20467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I700a486aa3c1ff5ef27f2db636a59cb404ddbb8e
Gerrit-Change-Number: 20467
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20467 )

Change subject: IMPALA-12402: v1 change the term from consistency to 
concurrency and fix nits
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20467/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/20467/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@368
PS1, Line 368: "concurrencyLevel={}", cacheSizeBytes/1024/1024, 
expirationSecs, concurrencyLevel);
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/20467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I700a486aa3c1ff5ef27f2db636a59cb404ddbb8e
Gerrit-Change-Number: 20467
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 08 Sep 2023 04:38:35 +
Gerrit-HasComments: Yes