[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 12 Sep 2023 16:34:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13984/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 12 Sep 2023 12:33:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 12 Sep 2023 12:16:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9706/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 12 Sep 2023 12:16:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Surya Hebbar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. IMPALA-12417: Fix query timeline issue during asynchronous codegen When ASYNC_CODEGEN = 1, async code generation is enabled, this switches the compiled function pointers during runtime. Hence, enabling codegen to run on a parallel thread. In this case, a new event sequence is added to each fragment's profile. These additional events exhaust the default phase's colors available and disturb the correlation between them. AsyncCodegen events can be skipped to render the fragment diagram correctly. Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe --- M www/query_timeline.tmpl 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20458/3 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20458/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20458/2//COMMIT_MSG@15 PS2, Line 15: corelation Nit: correlation. -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 08 Sep 2023 14:10:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 06 Sep 2023 14:24:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 13:57:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13926/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 13:51:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Surya Hebbar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. IMPALA-12417: Fix query timeline issue during asynchronous codegen When ASYNC_CODEGEN = 1, async code generation is enabled, this switches the compiled function pointers during runtime. Hence, enabling codegen to run on a parallel thread. In this case, a new event sequence is added to each fragment's profile. These additional events exhaust the default phase's colors available and disturb the corelation between them. AsyncCodegen events can be skipped to render the fragment diagram correctly. Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe --- M www/query_timeline.tmpl 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20458/2 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20458 Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. IMPALA-12417: Fix query timeline issue during asynchronous codegen When ASYNC_CODEGEN = 1, async code generation is enabled, this switches the compiled function pointers during runtime. Hence, enabling codegen to run on a parallel thread. In this case, a new event sequence is added to each fragment's profile. These additional events exhaust the default phase's colors available and disturb the corelation between them. AsyncCodegen events can be skipped to render the fragment diagram correctly. Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe --- M www/query_timeline.tmpl 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20458/1 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar
