[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20471 ) Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 In the change for IMPALA-11726, we added some usages of Guava's ImmutableMap.of() with >5 key/value pairs. This won't compile in older versions of Guava (like Guava 28) that only support up to 5 key/value pairs in ImmutableMap.of(). Being compatible with older versions of Guava makes it easier for Impala to match the Guava version of Hadoop, Hive, etc when compiling against older versions. This switches to using ImmutableMap.builder() to build the larger maps. Testing: - Built with Guava 28 and ran the tests Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Reviewed-on: http://gerrit.cloudera.org:8080/20471 Reviewed-by: Michael Smith Tested-by: Michael Smith --- M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTestBase.java 2 files changed, 32 insertions(+), 32 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Michael Smith has removed a vote on this change. Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20471 ) Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. Patch Set 1: Verified+1 Code-Review+2 Makes sense to me. Jenkins failed on https://issues.apache.org/jira/browse/IMPALA-12266. -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 11 Sep 2023 21:01:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20471 ) Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9698/ -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 11 Sep 2023 20:55:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20471 ) Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9698/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 11 Sep 2023 16:31:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20471 ) Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13960/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 09 Sep 2023 02:50:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20471 Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 In the change for IMPALA-11726, we added some usages of Guava's ImmutableMap.of() with >5 key/value pairs. This won't compile in older versions of Guava (like Guava 28) that only support up to 5 key/value pairs in ImmutableMap.of(). Being compatible with older versions of Guava makes it easier for Impala to match the Guava version of Hadoop, Hive, etc when compiling against older versions. This switches to using ImmutableMap.builder() to build the larger maps. Testing: - Built with Guava 28 and ran the tests Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 --- M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTestBase.java 2 files changed, 32 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/20471/1 -- To view, visit http://gerrit.cloudera.org:8080/20471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8 Gerrit-Change-Number: 20471 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
