[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-10-10 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20490 )

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20490/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20490/4//COMMIT_MSG@15
PS4, Line 15:
Can we add an e2e test for this? If the test requires no other queries are 
running at the same time, we can add an annotation of 
@pytest.mark.execute_serially on it, e.g.
https://github.com/apache/impala/blob/68c831176b82612f0146887e571554f20ce29c1e/tests/query_test/test_queries.py#L304



--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 4
Gerrit-Owner: ttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: ttz <2433038...@qq.com>
Gerrit-Comment-Date: Tue, 10 Oct 2023 10:09:41 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-09-19 Thread ttttttz (Code Review) 
Hello Quanlong Huang, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/20490

to look at the new patch set (#3).

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..

IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

In some cases, we shouldn't wait for the version specified in
'result.version' because the table version has not changed after
resetting metadata, such as refreshing a non-existent partition.
If not, the query may be stuck for a long time. This patch
determines whether to wait by comparing the table version before
and after resetting.

Change-Id: Iace7cdadda300b03896f92415822266354421887
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/20490/3
--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 3
Gerrit-Owner: ttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: ttz <2433038...@qq.com>

[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-09-19 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20490 )

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..


Patch Set 2:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/14022/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 2
Gerrit-Owner: ttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: ttz <2433038...@qq.com>
Gerrit-Comment-Date: Tue, 19 Sep 2023 09:45:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-09-19 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20490 )

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/14021/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 1
Gerrit-Owner: ttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: ttz <2433038...@qq.com>
Gerrit-Comment-Date: Tue, 19 Sep 2023 09:43:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-09-19 Thread ttttttz (Code Review) 
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/20490

to look at the new patch set (#2).

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..

IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

In some cases, we shouldn't wait for the version specified in
'result.version' because the table version has not changed after
resetting metadata, such as refreshing a non-existent partition.
If not, the query may be stuck for a long time.

Change-Id: Iace7cdadda300b03896f92415822266354421887
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/20490/2
--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 2
Gerrit-Owner: ttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-09-19 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20490 )

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20490/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/20490/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6663
PS1, Line 6663:   long syncDdlVersion = needWaitSyncDdlVersion ? 
catalog_.waitForSyncDdlVersion(resp.getResult()) : 0;
line too long (106 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 1
Gerrit-Owner: ttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 19 Sep 2023 09:18:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

2023-09-19 Thread ttttttz (Code Review) 
ttz has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/20490


Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partitions
..

IMPALA-12448: Avoid getting stuck when refreshing a non-existent partitions

In some cases, we shouldn't wait for the version specified in
'result.version' because the table version has not changed after
resetting metadata, such as refreshing a non-existent partition.
If not, the query may be stuck for a long time.

Change-Id: Iace7cdadda300b03896f92415822266354421887
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 12 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/20490/1
--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 1
Gerrit-Owner: ttz <2433038...@qq.com>