[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. IMPALA-12527: Fix Iceberg metadata table test S3 paths This commit excludes test_metadata_tables executions which could fail due to: 1) hardcoded uris in delete files 2) reused data load result, that points to a different file system Testing: - HDFS: tested in my local dev environment - S3: executed a jenkins job with the failing S3 parameters Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Reviewed-on: http://gerrit.cloudera.org:8080/20659 Tested-by: Impala Public Jenkins Reviewed-by: Zoltan Borok-Nagy Reviewed-by: Peter Rozsa --- M tests/query_test/test_iceberg.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Zoltan Borok-Nagy: Looks good to me, approved Peter Rozsa: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 5: Thank you for the reviews! I will split the tests with the STRUCT type addition. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 13 Nov 2023 09:27:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 5: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 13 Nov 2023 09:26:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 5: Code-Review+2 The change LGTM! But it would be good to add another test (maybe split the current test to two) that could be executed in all environments. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 13 Nov 2023 09:20:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Nov 2023 23:16:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9912/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Nov 2023 18:28:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/14393/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Nov 2023 14:56:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Tamas Mate has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. IMPALA-12527: Fix Iceberg metadata table test S3 paths This commit excludes test_metadata_tables executions which could fail due to: 1) hardcoded uris in delete files 2) reused data load result, that points to a different file system Testing: - HDFS: tested in my local dev environment - S3: executed a jenkins job with the failing S3 parameters Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 --- M tests/query_test/test_iceberg.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20659/5 -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9903/ -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 08 Nov 2023 19:20:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/14374/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 08 Nov 2023 15:23:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. IMPALA-12527: Fix Iceberg metadata table test S3 paths The Iceberg library does not necessarily add the filesystem prefix to the file paths, which can cause tests on different filesystems to fail. This change removes the filesystem checks from the file paths. Testing: - HDFS: tested in my local dev environment - S3: executed the test on with the failing S3 parameters Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 --- M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test M tests/query_test/test_iceberg.py 2 files changed, 43 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20659/4 -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9903/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 08 Nov 2023 14:57:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9896/ -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 Nov 2023 18:30:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20659/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/20659/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@26 PS2, Line 26: .* Do we need to change the results here even after annotating the test with SkipIf.hardcoded_uris? Btw, instead of $NAMENODE or '.*', $WAREHOUSE_LOCATION_PREFIX might be better. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 Nov 2023 14:11:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9896/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 Nov 2023 14:01:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9894/ -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 Nov 2023 13:19:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9894/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 Nov 2023 08:57:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9890/ -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 Nov 2023 00:35:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9890/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 06 Nov 2023 19:59:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/14332/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 06 Nov 2023 12:53:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20659 ) Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. IMPALA-12527: Fix Iceberg metadata table test S3 paths The Iceberg library does not necessarily add the filesystem prefix to the file paths, which can cause tests on different filesystems to fail. This change removes the filesystem checks from the file paths. Testing: - HDFS: tested in my local dev environment - S3: executed the jenkins job with the failing S3 parameters Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 --- M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test M tests/query_test/test_iceberg.py 2 files changed, 44 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20659/2 -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate
[Impala-ASF-CR] IMPALA-12527: Fix Iceberg metadata table test S3 paths
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20659 Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths .. IMPALA-12527: Fix Iceberg metadata table test S3 paths The Iceberg library does not necessarily add the filesystem prefix to the file paths, which can cause tests on different filesystems to fail. This change removes the filesystem checks from the file paths. Testing: - HDFS: tested in my local dev environment - S3: executed the test on with the failing S3 parameters Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 --- M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test M tests/query_test/test_iceberg.py 2 files changed, 44 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20659/1 -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate
