[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20776 Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. IMPALA-12614: Use atomics for 64-bit host metrics This patch changes 64-bit host metrics to use atomics to avoid potential partial load/store data races. There are no functional changes. This issue was exposed by TSAN tests when IMPALA-12385 enabled periodic metrics by default. Testing: TSAN tests cover this case. Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 --- M be/src/runtime/query-state.cc M be/src/util/system-state-info.cc M be/src/util/system-state-info.h 3 files changed, 13 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/20776/1 -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 1: Code-Review+2 LGTM, thanks for the quick fix -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 17:09:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/14671/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 17:18:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/14677/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 19:35:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 19:33:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20776 to look at the new patch set (#3). Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. IMPALA-12614: Use atomics for 64-bit host metrics This patch changes 64-bit host metrics to use atomics to avoid potential partial load/store data races. There are no functional changes. This issue was exposed by TSAN tests when IMPALA-12385 enabled periodic metrics by default. Testing: TSAN tests cover this case. Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 --- M be/src/runtime/query-state.cc M be/src/util/system-state-info-test.cc M be/src/util/system-state-info.cc M be/src/util/system-state-info.h 4 files changed, 18 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/20776/3 -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 3 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 3 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 21:42:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/14681/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 3 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 22:39:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10011/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 4 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 22:41:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 4 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 12 Dec 2023 22:41:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 4 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 13 Dec 2023 04:20:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. IMPALA-12614: Use atomics for 64-bit host metrics This patch changes 64-bit host metrics to use atomics to avoid potential partial load/store data races. There are no functional changes. This issue was exposed by TSAN tests when IMPALA-12385 enabled periodic metrics by default. Testing: TSAN tests cover this case. Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Reviewed-on: http://gerrit.cloudera.org:8080/20776 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/query-state.cc M be/src/util/system-state-info-test.cc M be/src/util/system-state-info.cc M be/src/util/system-state-info.h 4 files changed, 18 insertions(+), 17 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I88a15d3ccfeab29506427b3bfcaeebf3a2831176 Gerrit-Change-Number: 20776 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto
