[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default IMPALA_COMPRESSED_DEBUG_INFO was introduced in IMPALA-11511 and reduces Impala binary sizes by >50%. Debug tools like gdb and our minidump processing scripts handle compressed debug information properly. There are slightly higher link times and additional overhead when doing debugging. Overall, the reduction in binary sizes seems worth it given the modest overhead. Compressing the debug information also avoids concerns that adding debug information to toolchain components would increase binary sizes. This changes the default for IMPALA_COMPRESSED_DEBUG_INFO to true. Testing: - Ran pstack on a Centos 7 machine running tests with IMPALA_COMPRESSED_DEBUG_INFO=true and verified that the symbols work properly - Forced the production of minidumps for a job using IMPALA_COMPRESSED_DEBUG_INFO=true and verified it is processed properly. - Used this locally for development for several months Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Reviewed-on: http://gerrit.cloudera.org:8080/20871 Reviewed-by: Quanlong Huang Tested-by: Impala Public Jenkins --- M bin/impala-config.sh 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Quanlong Huang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 29 Apr 2024 21:06:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10589/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 29 Apr 2024 16:08:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. Patch Set 2: Code-Review+2 Carry Michael's +1 -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 29 Apr 2024 00:19:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 08 Jan 2024 22:22:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/14898/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 08 Jan 2024 20:45:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20871 Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default IMPALA_COMPRESSED_DEBUG_INFO was introduced in IMPALA-11511 and reduces Impala binary sizes by >50%. Debug tools like gdb and our minidump processing scripts handle compressed debug information properly. There are slightly higher link times and additional overhead when doing debugging. Overall, the reduction in binary sizes seems worth it given the modest overhead. Compressing the debug information also avoids concerns that adding debug information to toolchain components would increase binary sizes. This changes the default for IMPALA_COMPRESSED_DEBUG_INFO to true. Testing: - Ran pstack on a Centos 7 machine running tests with IMPALA_COMPRESSED_DEBUG_INFO=true and verified that the symbols work properly - Forced the production of minidumps for a job using IMPALA_COMPRESSED_DEBUG_INFO=true and verified it is processed properly. - Used this locally for development for several months Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 --- M bin/impala-config.sh 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/20871/1 -- To view, visit http://gerrit.cloudera.org:8080/20871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Gerrit-Change-Number: 20871 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
