[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sun, 04 Feb 2024 20:35:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause Earlier the ReachedLimit() condition was not evaluated during IcebergMetadataScanNode::GetNext(). This missing condition has been added and LIMIT is now being evaluated. Testing: - Added E2E test Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Reviewed-on: http://gerrit.cloudera.org:8080/20968 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10235/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sun, 04 Feb 2024 15:58:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sun, 04 Feb 2024 15:58:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20968/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/20968/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@300 PS1, Line 300: select snapshot_id from functional_parquet.iceberg_query_metadata.snapshots limit 2; > Done Done -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sun, 04 Feb 2024 03:54:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sun, 04 Feb 2024 01:44:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15145/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Fri, 02 Feb 2024 11:37:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause Earlier the ReachedLimit() condition was not evaluated during IcebergMetadataScanNode::GetNext(). This missing condition has been added and LIMIT is now being evaluated. Testing: - Added E2E test Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 --- M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20968/2 -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zihao Ye
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20968/1/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/20968/1/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc@198 PS1, Line 198: *eos = true; I think if we exit the loop because of row_batch->AtCapacity(), *eos should not be set to true, because we haven't reached the limit yet and there are more rows to scan. -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Tue, 30 Jan 2024 07:53:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20968/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/20968/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@300 PS1, Line 300: select snapshot_id from functional_parquet.iceberg_query_metadata.snapshots limit 2; Add check with low BATCH_SIZE option? https://impala.apache.org/docs/build/html/topics/impala_batch_size.html -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 29 Jan 2024 16:13:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20968/1/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/20968/1/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc@198 PS1, Line 198: *eos = true; Is GetNext() will be called again if *eos is true and last struct_like_row is not nullptr? -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 29 Jan 2024 16:12:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 ) Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15085/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Jan 2024 14:34:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20968 Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause .. IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause Earlier the ReachedLimit() condition was not evaluated during IcebergMetadataScanNode::GetNext(). This missing condition has been added and LIMIT is now being evaluated. Testing: - Added E2E test Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 --- M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20968/1 -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate
