[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20983 )

Change subject: IMPALA-12778: Fix time strings in catalog operations page
..

IMPALA-12778: Fix time strings in catalog operations page

In the /queries page of impalad, we are showing time strings using the
server timezone. However, in the /operations page of catalogd, UTC
timezone is used, which is confusing. This fixes the /operations page to
use the server timezone as well.

Tests
 - Add e2e test

Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Reviewed-on: http://gerrit.cloudera.org:8080/20983
Reviewed-by: Zihao Ye 
Reviewed-by: Wenzhe Zhou 
Tested-by: Impala Public Jenkins 
---
M be/src/catalog/catalog-server.cc
M tests/webserver/test_web_pages.py
2 files changed, 41 insertions(+), 2 deletions(-)

Approvals:
  Zihao Ye: Looks good to me, but someone else must approve
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Wenzhe Zhou 
Gerrit-Reviewer: Zihao Ye 


[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20983 )

Change subject: IMPALA-12778: Fix time strings in catalog operations page
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Wenzhe Zhou 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Fri, 02 Feb 2024 08:47:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20983 )

Change subject: IMPALA-12778: Fix time strings in catalog operations page
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10227/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Wenzhe Zhou 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Fri, 02 Feb 2024 04:22:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20983 )

Change subject: IMPALA-12778: Fix time strings in catalog operations page
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Wenzhe Zhou 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Fri, 02 Feb 2024 03:45:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20983 )

Change subject: IMPALA-12778: Fix time strings in catalog operations page
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Fri, 02 Feb 2024 03:37:08 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20983 )

Change subject: IMPALA-12778: Fix time strings in catalog operations page
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/15140/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 02 Feb 2024 03:10:27 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/20983


Change subject: IMPALA-12778: Fix time strings in catalog operations page
..

IMPALA-12778: Fix time strings in catalog operations page

In the /queries page of impalad, we are showing time strings using the
server timezone. However, in the /operations page of catalogd, UTC
timezone is used, which is confusing. This fixes the /operations page to
use the server timezone as well.

Tests
 - Add e2e test

Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
---
M be/src/catalog/catalog-server.cc
M tests/webserver/test_web_pages.py
2 files changed, 41 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/20983/1
--
To view, visit http://gerrit.cloudera.org:8080/20983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibebfc85267aabe9cef3a53f487d0ba53e050aa4c
Gerrit-Change-Number: 20983
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang