[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21151 Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions test_type_conversions_hive3 silently passes because we are not creating the test dimenstion for query option orc_shema_resolution correctly. If we set orc_shema_resolution correctly, i.e. to also exercise the name-based schema resolution, the test fails. The cause of the failure is that the ill-typed tables have dummy column names like 'c1', 'c2', etc. These are completely fine for position-based schema resolution, but it is not OK for name-based schema resolution. The test just wants to check error messages related to type errors, the column names are irrelevant, so we can just use the correct names. The test was copied from the old test_type_conversions_hive2 which is not relevant anymore, so this CR also removes it. Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 --- M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test M tests/query_test/test_scanners.py 2 files changed, 42 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21151/1 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Thu, 14 Mar 2024 20:20:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15520/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Thu, 14 Mar 2024 20:29:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21151/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21151/1//COMMIT_MSG@21 PS1, Line 21: test_type_conversions_hive2 Maybe one day we want to add this back for IMPALA-12349. It's ok to remove it here. -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 18 Mar 2024 13:05:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py@1717 PS2, Line 1717: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py@1717 PS2, Line 1717: # TODO(IMPALA-12349): Rename the columns to use the correct names (see line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 18 Mar 2024 16:14:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21151 to look at the new patch set (#2). Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions test_type_conversions_hive3 silently passes because we are not creating the test dimenstion for query option orc_shema_resolution correctly. If we set orc_shema_resolution correctly, i.e. to also exercise the name-based schema resolution, the test fails. The cause of the failure is that the ill-typed tables have dummy column names like 'c1', 'c2', etc. These are completely fine for position-based schema resolution, but it is not OK for name-based schema resolution. The test just wants to check error messages related to type errors, the column names are irrelevant, so we can just use the correct names. The test was copied from the old test_type_conversions_hive2 which is not relevant anymore, so this CR also removes it. Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 --- M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test M tests/query_test/test_scanners.py 2 files changed, 44 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21151/2 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21151 to look at the new patch set (#3). Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions test_type_conversions_hive3 silently passes because we are not creating the test dimenstion for query option orc_shema_resolution correctly. If we set orc_shema_resolution correctly, i.e. to also exercise the name-based schema resolution, the test fails. The cause of the failure is that the ill-typed tables have dummy column names like 'c1', 'c2', etc. These are completely fine for position-based schema resolution, but it is not OK for name-based schema resolution. The test just wants to check error messages related to type errors, the column names are irrelevant, so we can just use the correct names. The test was copied from the old test_type_conversions_hive2 which is not relevant anymore, so this CR also removes it. Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 --- M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test M tests/query_test/test_scanners.py 2 files changed, 44 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21151/3 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21151 to look at the new patch set (#4). Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions test_type_conversions_hive3 silently passes because we are not creating the test dimenstion for query option orc_shema_resolution correctly. If we set orc_shema_resolution correctly, i.e. to also exercise the name-based schema resolution, the test fails. The cause of the failure is that the ill-typed tables have dummy column names like 'c1', 'c2', etc. These are completely fine for position-based schema resolution, but it is not OK for name-based schema resolution. The test just wants to check error messages related to type errors, the column names are irrelevant, so we can just use the correct names. Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 --- M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test M tests/query_test/test_scanners.py 2 files changed, 44 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21151/4 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 4: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21151/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21151/1//COMMIT_MSG@21 PS1, Line 21: f3f3b1427b20a1d2d28 > Maybe one day we want to add this back for IMPALA-12349. It's ok to remove Thanks for pointing me to IMPALA-12349. If we have such plans then I think we shouldn't remove test_type_conversions_hive2 because we might forget to re-add it later. I didn't fix the column names in test_type_conversions_hive2 because I cannot test it, but at least I've left a hint for the future contributor of IMPALA-12349. http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py@1717 PS2, Line 1717: # TODO(IMPALA-12349): Rename the columns to use the correct names (see > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py@1717 PS2, Line 1717: > flake8: W291 trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 16:18:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15552/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 16:37:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15553/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 16:42:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 22:28:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 23:43:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10381/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 23:43:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 4: Code-Review+2 Carry Riza's +1. -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 23:42:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 4: Thank Riza and Zoltan for finding this issue! Merging this. -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 18 Mar 2024 23:43:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 19 Mar 2024 04:32:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions test_type_conversions_hive3 silently passes because we are not creating the test dimenstion for query option orc_shema_resolution correctly. If we set orc_shema_resolution correctly, i.e. to also exercise the name-based schema resolution, the test fails. The cause of the failure is that the ill-typed tables have dummy column names like 'c1', 'c2', etc. These are completely fine for position-based schema resolution, but it is not OK for name-based schema resolution. The test just wants to check error messages related to type errors, the column names are irrelevant, so we can just use the correct names. Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Reviewed-on: http://gerrit.cloudera.org:8080/21151 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test M tests/query_test/test_scanners.py 2 files changed, 44 insertions(+), 36 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy