[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 17 Apr 2024 14:03:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. IMPALA-13003: Handle Iceberg AlreadyExistsException When multiple coordinators attempt to create the same table concurrently with "if not exists", we still see AlreadyExistsException: Table was created concurrently: my_iceberg_tbl Iceberg throws its own version of AlreadyExistsException, but we avoid most code paths that would throw it because we first check HMS to see if the table exists before trying to create it. Updates createIcebergTable to handle Iceberg's AlreadyExistsException identically to the HMS AlreadyExistsException. Adds a test using DebugAction to simulate concurrent table creation. Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Reviewed-on: http://gerrit.cloudera.org:8080/21312 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/DebugUtils.java M tests/query_test/test_iceberg.py 3 files changed, 39 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. Patch Set 1: Code-Review+2 Thanks for fixing this, LGTM! -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 17 Apr 2024 08:59:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 17 Apr 2024 08:59:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10549/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 17 Apr 2024 08:59:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. Patch Set 1: Code-Review+1 LGTM will let Zoltan take a look -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 16 Apr 2024 22:39:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21312 ) Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15916/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 16 Apr 2024 22:21:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13003: Handle Iceberg AlreadyExistsException
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21312 Change subject: IMPALA-13003: Handle Iceberg AlreadyExistsException .. IMPALA-13003: Handle Iceberg AlreadyExistsException When multiple coordinators attempt to create the same table concurrently with "if not exists", we still see AlreadyExistsException: Table was created concurrently: my_iceberg_tbl Iceberg throws its own version of AlreadyExistsException, but we avoid most code paths that would throw it because we first check HMS to see if the table exists before trying to create it. Updates createIcebergTable to handle Iceberg's AlreadyExistsException identically to the HMS AlreadyExistsException. Adds a test using DebugAction to simulate concurrent table creation. Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/DebugUtils.java M tests/query_test/test_iceberg.py 3 files changed, 39 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/21312/1 -- To view, visit http://gerrit.cloudera.org:8080/21312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I847eea9297c9ee0d8e821fe1c87ea03d22f1d96e Gerrit-Change-Number: 21312 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith
