[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..

IMPALA-13040: (addendum) Inject larger delay for sanitized build

TestLateQueryStateInit has been flaky in sanitized build because the
largest delay injection time is fixed at 3 seconds. This patch fixes
the issue by setting largest delay injection time equal to
RUNTIME_FILTER_WAIT_TIME_MS, which is 3 second for regular build and 10
seconds for sanitized build.

Testing:
- Loop and pass test_runtime_filter_aggregation.py 10 times in ASAN
  build and 50 times in UBSAN build.

Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Reviewed-on: http://gerrit.cloudera.org:8080/21439
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M tests/custom_cluster/test_runtime_filter_aggregation.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Wed, 22 May 2024 01:40:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10657/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 21 May 2024 20:34:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10654/


--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 21 May 2024 19:25:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 21 May 2024 14:17:46 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10654/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 21 May 2024 14:17:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/16178/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Fri, 17 May 2024 18:58:19 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 2: Code-Review+2

Thanks Csaba! Carry +2. Will wait for https://gerrit.cloudera.org/c/21440/ to 
merge first.


-- 
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Fri, 17 May 2024 14:25:49 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Hello Laszlo Gaal, Csaba Ringhofer,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/21439

to look at the new patch set (#2).

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..

IMPALA-13040: (addendum) Inject larger delay for sanitized build

TestLateQueryStateInit has been flaky in sanitized build because the
largest delay injection time is fixed at 3 seconds. This patch fixes
the issue by setting largest delay injection time equal to
RUNTIME_FILTER_WAIT_TIME_MS, which is 3 second for regular build and 10
seconds for sanitized build.

Testing:
- Loop and pass test_runtime_filter_aggregation.py 10 times in ASAN
  build and 50 times in UBSAN build.

Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
---
M tests/custom_cluster/test_runtime_filter_aggregation.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/21439/2
--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21439 )

Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21439/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21439/1//COMMIT_MSG@10
PS1, Line 10: fix
nit: fixes



--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Fri, 17 May 2024 08:51:44 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21439


Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build
..

IMPALA-13040: (addendum) Inject larger delay for sanitized build

TestLateQueryStateInit has been flaky in sanitized build because the
largest delay injection time is fixed at 3 seconds. This patch fix the
issue by setting largest delay injection time equal to
RUNTIME_FILTER_WAIT_TIME_MS, which is 3 second for regular build and 10
seconds for sanitized build.

Testing:
- Loop and pass test_runtime_filter_aggregation.py 10 times in ASAN
  build and 50 times in UBSAN build.

Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
---
M tests/custom_cluster/test_runtime_filter_aggregation.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/21439/1
--
To view, visit http://gerrit.cloudera.org:8080/21439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09e5ae4646f53632e9a9f519d370a33a5534df19
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto