[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-21 Thread Daniel Becker (Code Review) 
Daniel Becker has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21440 )

Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..

IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables 
fails on an expected constant

IMPALA-13079 added a test in iceberg-metadata-tables.test that included
assertions about values that can change across builds, e.g. file sizes,
which caused test failures.

This commit fixes it by doing two things:
1. narrowing down the result set of the query to the column that the
   test is really about - this removes some of the problematic values
2. using regexes for the remaining problematic values.

Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Reviewed-on: http://gerrit.cloudera.org:8080/21440
Tested-by: Impala Public Jenkins 
Reviewed-by: Riza Suminto 
---
M 
testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Riza Suminto: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Peter Rozsa 
Gerrit-Reviewer: Riza Suminto

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-20 Thread Riza Suminto (Code Review) 
Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21440 )

Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21440/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21440/1//COMMIT_MSG@16
PS1, Line 16: problematic values
> Specifically mention which values are problematic. Is it just "column_size"
It seems to be the case. Marked this as Resolved.



--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Peter Rozsa 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Mon, 20 May 2024 23:59:11 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21440 )

Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Peter Rozsa 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Mon, 20 May 2024 23:52:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21440 )

Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10651/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Peter Rozsa 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Mon, 20 May 2024 18:42:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21440 )

Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/16177/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Peter Rozsa 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Fri, 17 May 2024 18:58:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Riza Suminto (Code Review) 
Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21440 )

Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21440/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21440/1//COMMIT_MSG@16
PS1, Line 16: problematic values
Specifically mention which values are problematic. Is it just "column_size"?



--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Peter Rozsa 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Fri, 17 May 2024 14:49:00 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Daniel Becker (Code Review) 
Daniel Becker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21440


Change subject: IMPALA-13091: 
query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an 
expected constant
..

IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables 
fails on an expected constant

IMPALA-13079 added a test in iceberg-metadata-tables.test that included
assertions about values that can change across builds, e.g. file sizes,
which caused test failures.

This commit fixes it by doing two things:
1. narrowing down the result set of the query to the column that the
   test is really about - this removes some of the problematic values
2. using regexes for the remaining problematic values.

Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
---
M 
testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/21440/1
--
To view, visit http://gerrit.cloudera.org:8080/21440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic056079eed87a68afa95cd111ce2037314cd9620
Gerrit-Change-Number: 21440
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker