[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8641 )

Change subject: IMPALA-3784: Fixed broken status-benchmark
..

IMPALA-3784: Fixed broken status-benchmark

A default constructed boost::optional is empty - it does
not contain a value, so get() cannot be called. The value
check should be required before using it.

Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Reviewed-on: http://gerrit.cloudera.org:8080/8641
Reviewed-by: Jim Apple 
Tested-by: Impala Public Jenkins
---
M be/src/benchmarks/status-benchmark.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 4
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Kim Jin Chul 

[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8641 )

Change subject: IMPALA-3784: Fixed broken status-benchmark
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Comment-Date: Mon, 27 Nov 2017 18:19:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8641 )

Change subject: IMPALA-3784: Fixed broken status-benchmark
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1522/


--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Comment-Date: Mon, 27 Nov 2017 14:42:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark

[Kim Jin Chul (Code Review)]

Hello Jim Apple,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8641

to look at the new patch set (#2).

Change subject: IMPALA-3784: Fixed broken status-benchmark
..

IMPALA-3784: Fixed broken status-benchmark

A default constructed boost::optional is empty - it does
not contain a value, so get() cannot be called. The value
check should be required before using it.

Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
---
M be/src/benchmarks/status-benchmark.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/8641/2
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Jim Apple