[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10316 Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f --- M docs/topics/impala_create_table.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/10316/1 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 1: Hi Joe, Have you had a chance to review this short update? -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 07 May 2018 21:09:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/10316 )
Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
..
Patch Set 1:
(1 comment)
Thanks for working on this. I noticed some other problems with the ordering, so
I think it would be good to fix these at the same time.
http://gerrit.cloudera.org:8080/#/c/10316/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:
http://gerrit.cloudera.org:8080/#/c/10316/1/docs/topics/impala_create_table.xml@172
PS1, Line 172: [COMMENT 'table_comment']
This bug is from a long time ago. In reviewing this, I noticed that there are
several other preexisting problems with our ordering here. Here is the order
that it should be:
PARTITIONED BY
SORT BY
COMMENT
ROW FORMAT
WITH SERDEPROPERTIES
STORED AS
LOCATION
CACHED IN, etc
TBLPROPERTIES
This ordering is the same across CREATE TABLE, CREATE TABLE AS SELECT, CREATE
TABLE LIKE {file format}. So, there are multiple locations on this page that
are incorrect.
CREATE TABLE LIKE {table} is different, so this doesn't apply to that.
--
To view, visit http://gerrit.cloudera.org:8080/10316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f
Gerrit-Change-Number: 10316
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni
Gerrit-Reviewer: Alex Rodoni
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Mon, 07 May 2018 22:08:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10316 to look at the new patch set (#2). Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f --- M docs/topics/impala_create_table.xml 1 file changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/10316/2 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10316/1/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/10316/1/docs/topics/impala_create_table.xml@172 PS1, Line 172: [COMMENT 'table_comment'] > This bug is from a long time ago. In reviewing this, I noticed that there a Done -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 07 May 2018 22:40:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/10316 )
Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10316/2/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:
http://gerrit.cloudera.org:8080/#/c/10316/2/docs/topics/impala_create_table.xml@a173
PS2, Line 173:
:
:
Do you know what the extra layer of []'s are about? I think we can remove them,
but I want to be sure I understand what they are for.
http://gerrit.cloudera.org:8080/#/c/10316/2/docs/topics/impala_create_table.xml@180
PS2, Line 180: [TBLPROPERTIES
('key1'='value1',
'key2'='value2', ...)]
Put this above the "data_type:"
--
To view, visit http://gerrit.cloudera.org:8080/10316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f
Gerrit-Change-Number: 10316
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni
Gerrit-Reviewer: Alex Rodoni
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Tue, 08 May 2018 19:45:52 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Alex Rodoni has posted comments on this change. (
http://gerrit.cloudera.org:8080/10316 )
Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10316/2/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:
http://gerrit.cloudera.org:8080/#/c/10316/2/docs/topics/impala_create_table.xml@a173
PS2, Line 173:
:
:
> Do you know what the extra layer of []'s are about? I think we can remove t
I do not know why it is structured this way - 2 layers of optional.
http://gerrit.cloudera.org:8080/#/c/10316/2/docs/topics/impala_create_table.xml@180
PS2, Line 180: [TBLPROPERTIES
('key1'='value1',
'key2'='value2', ...)]
> Put this above the "data_type:"
Done
--
To view, visit http://gerrit.cloudera.org:8080/10316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f
Gerrit-Change-Number: 10316
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni
Gerrit-Reviewer: Alex Rodoni
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Tue, 08 May 2018 19:52:25 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Code-Review+2 Assuming that one change is done, this looks good. Just as a reference, fe/src/main/cup/sql-parser.cup defines our parsing rules. The variable that shows the ordering is tbl_options (apart from the "partitioned by"). The "partitioned by" comes from a couple different places. Sometimes it is hard coded with "KW_PARTITIONED KW_BY". Sometimes it comes from partitioned_data_layout. Sometimes it comes from partition_column_defs. -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:35:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: > Assuming that one change is done, this looks good. > > Just as a reference, fe/src/main/cup/sql-parser.cup defines our > parsing rules. The variable that shows the ordering is tbl_options > (apart from the "partitioned by"). The "partitioned by" comes from > a couple different places. Sometimes it is hard coded with > "KW_PARTITIONED KW_BY". Sometimes it comes from partitioned_data_layout. > Sometimes it comes from partition_column_defs. > Assuming that one change is done, this looks good. > > Just as a reference, fe/src/main/cup/sql-parser.cup defines our > parsing rules. The variable that shows the ordering is tbl_options > (apart from the "partitioned by"). The "partitioned by" comes from > a couple different places. Sometimes it is hard coded with > "KW_PARTITIONED KW_BY". Sometimes it comes from partitioned_data_layout. > Sometimes it comes from partition_column_defs. Thank you! I will make a note. -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:46:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/283/ -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:47:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Code-Review-2 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:47:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: This needs another upload before any submit. -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:48:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10316 to look at the new patch set (#3). Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f --- M docs/topics/impala_create_table.xml 1 file changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/10316/3 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Removed Code-Review-2 by Joe McDonnell -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10316/3/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/10316/3/docs/topics/impala_create_table.xml@181 PS3, Line 181: One tiny nit: can we get rid of this stray new line? -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:56:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 20:57:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10316 to look at the new patch set (#4). Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f --- M docs/topics/impala_create_table.xml 1 file changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/10316/4 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10316/3/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/10316/3/docs/topics/impala_create_table.xml@181 PS3, Line 181: > One tiny nit: can we get rid of this stray new line? Done -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 21:08:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 21:15:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/284/ -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 21:20:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Reviewed-on: http://gerrit.cloudera.org:8080/10316 Reviewed-by: Joe McDonnell Tested-by: Impala Public Jenkins --- M docs/topics/impala_create_table.xml 1 file changed, 10 insertions(+), 13 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 08 May 2018 21:31:44 + Gerrit-HasComments: No
