[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13889 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Jul 2019 07:13:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13889 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the standard says: When an expression that has integral type is added to or subtracted from a pointer, the result has the type of the pointer operand. ... If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined. This is triggered in the end-to-end tests.h The interesting part of the backtrace is: exec/parquet/hdfs-parquet-scanner.cc:1405:45: runtime error: pointer index expression with base 0x1300e0e9 overflowed to 0x1300e0ea #0 HdfsParquetScanner::ProcessFooter() exec/parquet/hdfs-parquet-scanner.cc:1405:45 #1 HdfsParquetScanner::Open(ScannerContext*) exec/parquet/hdfs-parquet-scanner.cc:186:26 #2 HdfsScanNodeBase::CreateAndOpenScannerHelper( HdfsPartitionDescriptor*, ScannerContext*, scoped_ptr*) exec/hdfs-scan-node-base.cc:721:59 #3 HdfsScanNodeMt::CreateAndOpenScanner(HdfsPartitionDescriptor*, ScannerContext*, scoped_ptr*) exec/hdfs-scan-node-mt.cc:127:19 #4 HdfsScanNodeMt::GetNext(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node-mt.cc:97:21 Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Reviewed-on: http://gerrit.cloudera.org:8080/13889 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/parquet/hdfs-parquet-scanner.cc 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13889 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Jul 2019 00:46:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13889 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4651/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Jul 2019 00:46:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13889 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 24 Jul 2019 22:45:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13889 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3938/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Jul 2019 01:17:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13889 Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the standard says: When an expression that has integral type is added to or subtracted from a pointer, the result has the type of the pointer operand. ... If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined. This is triggered in the end-to-end tests.h The interesting part of the backtrace is: exec/parquet/hdfs-parquet-scanner.cc:1405:45: runtime error: pointer index expression with base 0x1300e0e9 overflowed to 0x1300e0ea #0 HdfsParquetScanner::ProcessFooter() exec/parquet/hdfs-parquet-scanner.cc:1405:45 #1 HdfsParquetScanner::Open(ScannerContext*) exec/parquet/hdfs-parquet-scanner.cc:186:26 #2 HdfsScanNodeBase::CreateAndOpenScannerHelper( HdfsPartitionDescriptor*, ScannerContext*, scoped_ptr*) exec/hdfs-scan-node-base.cc:721:59 #3 HdfsScanNodeMt::CreateAndOpenScanner(HdfsPartitionDescriptor*, ScannerContext*, scoped_ptr*) exec/hdfs-scan-node-mt.cc:127:19 #4 HdfsScanNodeMt::GetNext(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node-mt.cc:97:21 Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f --- M be/src/exec/parquet/hdfs-parquet-scanner.cc 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/13889/1 -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the standard says: When an expression that has integral type is added to or subtracted from a pointer, the result has the type of the pointer operand. ... If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined. In the end-to-end tests this is triggered, and the interesting part of the backtrace is: include/c++/4.9.2/bits/stl_iterator.h:782:45: runtime error: pointer index expression with base 0x overflowed to 0xffe8 #0 __normal_iterator>::operator+(long) const stl_iterator.h:782:45 #1 MemPool::AcquireData(MemPool*, bool) runtime/mem-pool.cc:190:62 #2 RowBatch::TransferResourceOwnership(RowBatch*) runtime/row-batch.cc:444:26 #3 RowBatch::AcquireState(RowBatch*) runtime/row-batch.cc:505:8 #4 HdfsScanNode::GetNextInternal(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node.cc:105:16 #5 HdfsScanNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node.cc:81:19 #6 StreamingAggregationNode::GetRowsStreaming(RuntimeState*, RowBatch*) exec/streaming-aggregation-node.cc:116:51 #7 StreamingAggregationNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/streaming-aggregation-node.cc:92:41 Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Reviewed-on: http://gerrit.cloudera.org:8080/8 Reviewed-by: Jim Apple Tested-by: Jim Apple --- M be/src/runtime/mem-pool.cc 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jim Apple: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Aug 2018 16:14:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Aug 2018 16:14:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2928/ > > Very strange: > > + rm -rf /home/ubuntu/Impala > rm: cannot remove '/home/ubuntu/Impala': Directory not empty Other pre-commit jobs completed fine: https://jenkins.impala.io/job/parallel-all-tests/3936/console Rerunning all-build-options: https://jenkins.impala.io/job/all-build-options-ub1604/2268/console If that passes, I'll manually +Verify. -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Aug 2018 21:54:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2928/ Very strange: + rm -rf /home/ubuntu/Impala rm: cannot remove '/home/ubuntu/Impala': Directory not empty -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Aug 2018 21:40:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2928/ -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Aug 2018 21:33:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2928/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Aug 2018 18:14:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 3: Code-Review+2 carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Aug 2018 18:13:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/182/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 03 Aug 2018 23:31:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/181/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 03 Aug 2018 23:19:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8 to look at the new patch set (#2). Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the standard says: When an expression that has integral type is added to or subtracted from a pointer, the result has the type of the pointer operand. ... If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined. In the end-to-end tests this is triggered, and the interesting part of the backtrace is: include/c++/4.9.2/bits/stl_iterator.h:782:45: runtime error: pointer index expression with base 0x overflowed to 0xffe8 #0 __normal_iterator>::operator+(long) const stl_iterator.h:782:45 #1 MemPool::AcquireData(MemPool*, bool) runtime/mem-pool.cc:190:62 #2 RowBatch::TransferResourceOwnership(RowBatch*) runtime/row-batch.cc:444:26 #3 RowBatch::AcquireState(RowBatch*) runtime/row-batch.cc:505:8 #4 HdfsScanNode::GetNextInternal(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node.cc:105:16 #5 HdfsScanNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node.cc:81:19 #6 StreamingAggregationNode::GetRowsStreaming(RuntimeState*, RowBatch*) exec/streaming-aggregation-node.cc:116:51 #7 StreamingAggregationNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/streaming-aggregation-node.cc:92:41 Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 --- M be/src/runtime/mem-pool.cc 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8/2 -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8/1/be/src/runtime/mem-pool.cc File be/src/runtime/mem-pool.cc: http://gerrit.cloudera.org:8080/#/c/8/1/be/src/runtime/mem-pool.cc@190 PS1, Line 190: vector::iterator insert_chunk = chunks_.begin() + (current_chunk_idx_ + 1); I had to stare at this for a minute. Is the bug in the case when current_chunk_idx_ is -1? I always found the current_chunk_idx_ logic here confusing... The new code seems fine, might be worth dropping a comment to explain why the parens are significant. -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 03 Aug 2018 22:50:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8 ) Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 03 Aug 2018 22:50:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8 Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the standard says: When an expression that has integral type is added to or subtracted from a pointer, the result has the type of the pointer operand. ... If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined. In the end-to-end tests this is triggered, and the interesting part of the backtrace is: include/c++/4.9.2/bits/stl_iterator.h:782:45: runtime error: pointer index expression with base 0x overflowed to 0xffe8 #0 __normal_iterator>::operator+(long) const stl_iterator.h:782:45 #1 MemPool::AcquireData(MemPool*, bool) runtime/mem-pool.cc:190:62 #2 RowBatch::TransferResourceOwnership(RowBatch*) runtime/row-batch.cc:444:26 #3 RowBatch::AcquireState(RowBatch*) runtime/row-batch.cc:505:8 #4 HdfsScanNode::GetNextInternal(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node.cc:105:16 #5 HdfsScanNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node.cc:81:19 #6 StreamingAggregationNode::GetRowsStreaming(RuntimeState*, RowBatch*) exec/streaming-aggregation-node.cc:116:51 #7 StreamingAggregationNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/streaming-aggregation-node.cc:92:41 Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 --- M be/src/runtime/mem-pool.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8/1 -- To view, visit http://gerrit.cloudera.org:8080/8 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3d28a80763adb62572b3dd81ea732d18d957d248 Gerrit-Change-Number: 8 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple