[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..

IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell options

This patch adds --auth_creds_ok_in_clear to the impala_shell_options
documentation xml

Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Reviewed-on: http://gerrit.cloudera.org:8080/10236
Reviewed-by: Jim Apple 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_shell_options.xml
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 3
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 2
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com
Gerrit-Comment-Date: Tue, 08 May 2018 17:34:35 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/281/


--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 2
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com
Gerrit-Comment-Date: Tue, 08 May 2018 17:17:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 2
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com
Gerrit-Comment-Date: Tue, 08 May 2018 17:17:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Anonymous Coward (Code Review)]

Hello Alex Rodoni, Jim Apple,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10236

to look at the new patch set (#2).

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..

IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell options

This patch adds --auth_creds_ok_in_clear to the impala_shell_options
documentation xml

Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
---
M docs/topics/impala_shell_options.xml
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/10236/2
--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 2
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 1:

> > (2 comments)
 > >
 > > Thank you for contributing! Some review comments are below:
 >
 > Hi Jim,
 > Thank you for your comments.
 >
 > For Line 560: I reached out to Alex for this. My understanding was
 > that this revision number is for the version in which the
 > documentation included this shell option in its xml. Since the
 > feature is tagged with the revision it was included in. I was
 > wrong, I'll revise it.
 >
 > For Line 562: I tested this within my bootstrapped development
 > environment, after building using buildall.sh and then executing
 > start-impala-cluster.py. I checked by passing the option as an
 > argument to the impala-shell and it was accepted. When I inserted
 > it into the ~/.impalarc file as a key-value pair: auth_creds_ok_in_clear=true
 > or even creds_ok_in_clear=true it displayed – “WARNING: Unable to
 > read configuration file correctly. Ignoring unrecognized config
 > option: 'auth_creds_ok_in_clear'.”
 > I also tested this on another test cluster I had access to with the
 > same result.
 >
 > Thanks!

Great! To fix this, you'll need to commit, squash, then git push to the same 
gerrit repo you pushed to when you created this patch. You can email 
d...@impala.apache.org with details if you get stuck.


--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com
Gerrit-Comment-Date: Fri, 04 May 2018 21:30:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Anonymous Coward (Code Review)]

shashanknaik...@gmail.com has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 1:

> (2 comments)
 >
 > Thank you for contributing! Some review comments are below:

Hi Jim,
Thank you for your comments.

For Line 560: I reached out to Alex for this. My understanding was that this 
revision number is for the version in which the documentation included this 
shell option in its xml. Since the feature is tagged with the revision it was 
included in. I was wrong, I'll revise it.

For Line 562: I tested this within my bootstrapped development environment, 
after building using buildall.sh and then executing start-impala-cluster.py. I 
checked by passing the option as an argument to the impala-shell and it was 
accepted. When I inserted it into the ~/.impalarc file as a key-value pair: 
auth_creds_ok_in_clear=true or even creds_ok_in_clear=true it displayed – 
“WARNING: Unable to read configuration file correctly. Ignoring unrecognized 
config option: 'auth_creds_ok_in_clear'.”
I also tested this on another test cluster I had access to with the same result.

Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: shashanknaik...@gmail.com
Gerrit-Comment-Date: Tue, 01 May 2018 15:18:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 1:

(2 comments)

Thank you for contributing! Some review comments are below:

http://gerrit.cloudera.org:8080/#/c/10236/1/docs/topics/impala_shell_options.xml
File docs/topics/impala_shell_options.xml:

http://gerrit.cloudera.org:8080/#/c/10236/1/docs/topics/impala_shell_options.xml@560
PS1, Line 560: 2.12.0 IMPALA-5969
This was IMPALA-2143, in a much older version of Impala. 2.3 or before.


http://gerrit.cloudera.org:8080/#/c/10236/1/docs/topics/impala_shell_options.xml@562
PS1, Line 562: >N/A<
How did you check that this cannot be done in a config file?



--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Mon, 30 Apr 2018 21:09:49 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Anonymous Coward (Code Review)]

shashanknaik...@gmail.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10236


Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..

IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell options

This patch adds --auth_creds_ok_in_clear to the impala_shell_options
documentation xml

Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
---
M docs/topics/impala_shell_options.xml
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/10236/1
--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple