[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 05 Apr 2019 00:43:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable User can set environment variable PYTHON_EGG_CACHE before call impala-shell. Testing: Run impala-shell with or w/o PYTHON_EGG_CACHE configured Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Reviewed-on: http://gerrit.cloudera.org:8080/12911 Tested-by: Impala Public Jenkins Reviewed-by: Bharath Vissapragada --- M shell/impala-shell 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Bharath Vissapragada: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 05 Apr 2019 00:36:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3985/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 04 Apr 2019 19:56:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2649/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 04 Apr 2019 19:42:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2645/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 04 Apr 2019 19:16:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Change to "it" -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 04 Apr 2019 19:08:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Hello Bharath Vissapragada, Andrew Sherman, Lars Volker, Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12911 to look at the new patch set (#3). Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable User can set environment variable PYTHON_EGG_CACHE before call impala-shell. Testing: Run impala-shell with or w/o PYTHON_EGG_CACHE configured Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 --- M shell/impala-shell 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/12911/3 -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12911/2/shell/impala-shell File shell/impala-shell: http://gerrit.cloudera.org:8080/#/c/12911/2/shell/impala-shell@39 PS2, Line 39: EGG_CACHE nit: May be just say "By default it is set" Seems obvious that we are referring to the the pyegg cache. -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 04 Apr 2019 18:39:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 2: (1 comment) Submit patch 2 to address review issues. http://gerrit.cloudera.org:8080/#/c/12911/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12911/1//COMMIT_MSG@13 PS1, Line 13: Run impala-shell with or w/o PYTHON_EGG_CACHE configured > I thought this wrapper is bypassed when calling bin/impala-shell.sh . Did y I did not call impala-shell.sh to test, just call shell/impala-shell -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 04 Apr 2019 18:32:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Hello Bharath Vissapragada, Andrew Sherman, Lars Volker, Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12911 to look at the new patch set (#2). Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable User can set environment variable PYTHON_EGG_CACHE before call impala-shell. Testing: Run impala-shell with or w/o PYTHON_EGG_CACHE configured Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 --- M shell/impala-shell 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/12911/2 -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/12911 )
Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12911/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12911/1//COMMIT_MSG@13
PS1, Line 13: Run impala-shell with or w/o PYTHON_EGG_CACHE configured
I thought this wrapper is bypassed when calling bin/impala-shell.sh . Did you
build a tar ball and test this script?
http://gerrit.cloudera.org:8080/#/c/12911/1/shell/impala-shell
File shell/impala-shell:
http://gerrit.cloudera.org:8080/#/c/12911/1/shell/impala-shell@41
PS1, Line 41: if [ ! ${PYTHON_EGG_CACHE} ]; then
: PYTHON_EGG_CACHE=/tmp/impala-shell-python-egg-cache-${USER}
: fi
I think this can be simplified to foo=${foo:-bar} style
--
To view, visit http://gerrit.cloudera.org:8080/12911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508
Gerrit-Change-Number: 12911
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen
Gerrit-Reviewer: Andrew Sherman
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Laszlo Gaal
Gerrit-Comment-Date: Thu, 04 Apr 2019 16:26:30 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Thu, 04 Apr 2019 16:22:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2611/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 02 Apr 2019 14:45:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12911 Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable User can set environment variable PYTHON_EGG_CACHE before call impala-shell. Testing: Run impala-shell with or w/o PYTHON_EGG_CACHE configured Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 --- M shell/impala-shell 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/12911/1 -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen
