[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. .. IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. IMPALA-5599 changed the precision of query start and end time date-time string representations to microseconds. This ended up breaking compatibility with some API clients. This patch restores the precision to nanosecond, even though the timestamps themselves have only microsecond precision. Effectively, what we end up doing is to zero-pad the fractional second part to nine decimal places. I have manually checked from the Impala debug web page that the start and end times of queries have nanosecond precision: Start Time: 2017-11-20 14:59:01.954031000 End Time: 2017-11-20 15:00:02.103735000 This is basically the same as how it was before. The following is taken from a cluster running Impala 2.11: Start Time: 2017-11-20 14:17:52.19827 End Time: 2017-11-20 14:18:52.242868000 Test cases that inspect timestamps of Impala query profiles from the debug web page will be introduced in a follow-on commit. Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Reviewed-on: http://gerrit.cloudera.org:8080/8611 Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M be/src/service/client-request-state.cc M be/src/service/impala-http-handler.cc M be/src/util/time.h 3 files changed, 14 insertions(+), 8 deletions(-) Approvals: Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 9 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 8 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 27 Nov 2017 23:43:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1526/ -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 8 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 27 Nov 2017 20:08:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 8 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 27 Nov 2017 20:06:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.
Hello Michael Ho, Philip Zeyliger, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8611 to look at the new patch set (#8). Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. .. IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. IMPALA-5599 changed the precision of query start and end time date-time string representations to microseconds. This ended up breaking compatibility with some API clients. This patch restores the precision to nanosecond, even though the timestamps themselves have only microsecond precision. Effectively, what we end up doing is to zero-pad the fractional second part to nine decimal places. I have manually checked from the Impala debug web page that the start and end times of queries have nanosecond precision: Start Time: 2017-11-20 14:59:01.954031000 End Time: 2017-11-20 15:00:02.103735000 This is basically the same as how it was before. The following is taken from a cluster running Impala 2.11: Start Time: 2017-11-20 14:17:52.19827 End Time: 2017-11-20 14:18:52.242868000 Test cases that inspect timestamps of Impala query profiles from the debug web page will be introduced in a follow-on commit. Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 --- M be/src/service/client-request-state.cc M be/src/service/impala-http-handler.cc M be/src/util/time.h 3 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8611/8 -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 8 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Zoram Thanga
