[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. CTAS into Kudu fails if the primary key and/or the partition column names are not specified in lower case.The problem is that we pass in the primary key column names directly from the parser instead we should be passing the post-analysis ColumnDefs as primary keys. So it is fixed by making changes to createCtasTarget() in KuduTable class to take a list of ColumnDef class associated with the primary keys from getPrimaryKeyColumnDefs() in CreateTableStmt class. ColumnDef class has column names stored in lower case that are used by createCtasTarget() to populate primaryKeyColumnNames_ in KuduTable class that resolves the issue. Testing --- Verified against the newly added test case that reproduces the issue without the fix. Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Reviewed-on: http://gerrit.cloudera.org:8080/9147 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java 4 files changed, 14 insertions(+), 5 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 11 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 10 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Thu, 01 Feb 2018 04:34:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1850/ -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 10 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Thu, 01 Feb 2018 00:38:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 10 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Thu, 01 Feb 2018 00:37:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#10). Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. CTAS into Kudu fails if the primary key and/or the partition column names are not specified in lower case.The problem is that we pass in the primary key column names directly from the parser instead we should be passing the post-analysis ColumnDefs as primary keys. So it is fixed by making changes to createCtasTarget() in KuduTable class to take a list of ColumnDef class associated with the primary keys from getPrimaryKeyColumnDefs() in CreateTableStmt class. ColumnDef class has column names stored in lower case that are used by createCtasTarget() to populate primaryKeyColumnNames_ in KuduTable class that resolves the issue. Testing --- Verified against the newly added test case that reproduces the issue without the fix. Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java 4 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9147/10 -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 10 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Pranay Singh has posted comments on this change. (
http://gerrit.cloudera.org:8080/9147 )
Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or
primary key column names.
..
Patch Set 9:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@321
PS9, Line 321: List PrimaryKeyColumnDefs,
List partitionParams) {
> style: PrimaryKeyColumnDefs -> primaryKeyColumnDefs
Done
http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@327
PS9, Line 327: for (ColumnDef pk_coldef: PrimaryKeyColumnDefs) {
> pk_coldef -> pkColDef
Done
http://gerrit.cloudera.org:8080/#/c/9147/9/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test:
http://gerrit.cloudera.org:8080/#/c/9147/9/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@290
PS9, Line 290:
> revert
Done
--
To view, visit http://gerrit.cloudera.org:8080/9147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2
Gerrit-Change-Number: 9147
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:03:56 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Alex Behm has posted comments on this change. (
http://gerrit.cloudera.org:8080/9147 )
Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or
primary key column names.
..
Patch Set 9:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@321
PS9, Line 321: List PrimaryKeyColumnDefs,
List partitionParams) {
style: PrimaryKeyColumnDefs -> primaryKeyColumnDefs
http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@327
PS9, Line 327: for (ColumnDef pk_coldef: PrimaryKeyColumnDefs) {
pk_coldef -> pkColDef
http://gerrit.cloudera.org:8080/#/c/9147/9/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test:
http://gerrit.cloudera.org:8080/#/c/9147/9/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@290
PS9, Line 290:
revert
--
To view, visit http://gerrit.cloudera.org:8080/9147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2
Gerrit-Change-Number: 9147
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Wed, 31 Jan 2018 22:38:48 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#9). Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. CTAS into Kudu fails if the primary key and/or the partition column names are not specified in lower case.The problem is that we pass in the primary key column names directly from the parser instead we should be passing the post-analysis ColumnDefs as primary keys. So it is fixed by making changes to createCtasTarget() in KuduTable class to take a list of ColumnDef class associated with the primary keys from getPrimaryKeyColumnDefs() in CreateTableStmt class. ColumnDef class has column names stored in lower case that are used by createCtasTarget() to populate primaryKeyColumnNames_ in KuduTable class that resolves the issue. Testing --- Verified against the newly added test case that reproduces the issue without the fix. Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 5 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9147/9 -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 9 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#8). Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. CTAS into Kudu fails if the primary key and/or the partition column names are not specified in lower case.The problem is that we pass in the primary key column names directly from the parser instead we should be passing the post-analysis ColumnDefs as primary keys. So it is fixed by making changes to createCtasTarget() in KuduTable class to take a list of ColumnDef class associated with the primary keys from getPrimaryKeyColumnDefs() in CreateTableStmt class. ColumnDef class has column names stored in lower case that are used by createCtasTarget() to populate primaryKeyColumnNames_ in KuduTable class that resolves the issue. Testing --- Verified against the newly added test case that reproduces the issue without the fix. Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 5 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9147/8 -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 8 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh
[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#7). Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. CTAS into Kudu fails if the primary key and/or the partition column names are not specified in lower case.The problem is that we pass in the primary key column names directly from the parser instead we should be passing the post-analysis ColumnDefs as primary keys. So it is fixed by making changes to createCtasTarget() in KuduTable clqss to take a list of ColumnDef class associated with the primary keys from getPrimaryKeyColumnDefs() in CreateTableStmt class. ColumnDef class has column names stored in lower case that are used by createCtasTarget() to populate primaryKeyColumnNames_ in KuduTable class that resolves the issue. Testing --- Verified against the newly added test case that reproduces the issue without the fix. Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 5 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9147/7 -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 7 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh
