[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 20 Apr 2018 19:45:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..

IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

Adds new materials under COMPUTE STATS describing
the experimental stats extrapolation and sampling
features.

More cleanup and examples are needed. This patch provides
a reasonable starting point which we can extend.

Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Reviewed-on: http://gerrit.cloudera.org:8080/10112
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_perf_stats.xml
1 file changed, 135 insertions(+), 0 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/256/


--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 20 Apr 2018 19:25:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2347/


--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 20 Apr 2018 19:25:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-20 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 2: Code-Review+2

Yes


--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Comment-Date: Fri, 20 Apr 2018 19:24:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-20 Thread Alex Rodoni (Code Review) 
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 2:

Is this ready to be merged?


--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Comment-Date: Fri, 20 Apr 2018 15:25:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-18 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 1:

(2 comments)

Thanks for the review!

http://gerrit.cloudera.org:8080/#/c/10112/1/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:

http://gerrit.cloudera.org:8080/#/c/10112/1/docs/topics/impala_perf_stats.xml@449
PS1, Line 449: an excessive
> Nit: replace with the numerical value and skip the adjective
Good point. Done.


http://gerrit.cloudera.org:8080/#/c/10112/1/docs/topics/impala_perf_stats.xml@492
PS1, Line 492: please tell us about your experience
> Should we recommend where to give such feedback?
Good idea. I added u...@impala.apache.org



--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Comment-Date: Thu, 19 Apr 2018 05:20:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-18 Thread Alex Behm (Code Review) 
Hello Greg Rahn, Alex Rodoni,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10112

to look at the new patch set (#2).

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..

IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

Adds new materials under COMPUTE STATS describing
the experimental stats extrapolation and sampling
features.

More cleanup and examples are needed. This patch provides
a reasonable starting point which we can extend.

Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
---
M docs/topics/impala_perf_stats.xml
1 file changed, 135 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/10112/2
--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-18 Thread Greg Rahn (Code Review) 
Greg Rahn has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 1: Code-Review+2

(2 comments)

Review comments, otherwise +2

http://gerrit.cloudera.org:8080/#/c/10112/1/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:

http://gerrit.cloudera.org:8080/#/c/10112/1/docs/topics/impala_perf_stats.xml@449
PS1, Line 449: an excessive
Nit: replace with the numerical value and skip the adjective


http://gerrit.cloudera.org:8080/#/c/10112/1/docs/topics/impala_perf_stats.xml@492
PS1, Line 492: please tell us about your experience
Should we recommend where to give such feedback?



--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Comment-Date: Thu, 19 Apr 2018 05:05:56 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-18 Thread Alex Rodoni (Code Review) 
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10112 )

Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:16:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

2018-04-18 Thread Alex Behm (Code Review) 
Alex Behm has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10112


Change subject: IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.
..

IMPALA-6459: [DOCS] Part 2: Stats extrapolation and sampling.

Adds new materials under COMPUTE STATS describing
the experimental stats extrapolation and sampling
features.

More cleanup and examples are needed. This patch provides
a reasonable starting point which we can extend.

Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
---
M docs/topics/impala_perf_stats.xml
1 file changed, 134 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/10112/1
--
To view, visit http://gerrit.cloudera.org:8080/10112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idae7a377b5873701e91f60afa62dde2bd8aacd1b
Gerrit-Change-Number: 10112
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm