[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. IMPALA-6642 (Part 2): clean up start-impala-cluster.py We clean up start-impala-cluster.py in general in this patch by using logging instead of "print" and formatting strings using the format() function. We make sure to include a timestamp in each log message in order to make it easier to debug failures in custom cluster tests that happen when starting the cluster. Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Reviewed-on: http://gerrit.cloudera.org:8080/10780 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/start-impala-cluster.py M tests/common/impala_service.py 2 files changed, 147 insertions(+), 83 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 10780 Gerrit-PatchSet: 4 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 10780 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Sat, 07 Jul 2018 01:10:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 10780 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 06 Jul 2018 22:07:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2779/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 10780 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 06 Jul 2018 22:07:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 10780 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 06 Jul 2018 21:44:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. IMPALA-6642 (Part 2): clean up start-impala-cluster.py We clean up start-impala-cluster.py in general in this patch by using logging instead of "print" and formatting strings using the format() function. We make sure to include a timestamp in each log message in order to make it easier to debug failures in custom cluster tests that happen when starting the cluster. Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 --- M bin/start-impala-cluster.py M tests/common/impala_service.py 2 files changed, 147 insertions(+), 83 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10780/2 -- To view, visit http://gerrit.cloudera.org:8080/10780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 10780 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tianyi Wang
