[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. Patch Set 1: (2 comments) Thanks for the review. I saw your change and copied over the relevant parts to here. http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc@81 PS1, Line 81: deferred > early Done http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc@83 PS1, Line 83: mem_tracker_ > This should probably renamed to a more meaningful name such as " early_rpcs Done -- To view, visit http://gerrit.cloudera.org:8080/9633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb72c28e8d660a6b78543dbc8b5b156e0e7c843 Gerrit-Change-Number: 9633 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Wed, 14 Mar 2018 17:59:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc@81 PS1, Line 81: deferred early http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc@83 PS1, Line 83: mem_tracker_ This should probably renamed to a more meaningful name such as " early_rpcs_tracker_" -- To view, visit http://gerrit.cloudera.org:8080/9633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb72c28e8d660a6b78543dbc8b5b156e0e7c843 Gerrit-Change-Number: 9633 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Wed, 14 Mar 2018 17:52:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9633 Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. IMPALA-6652: Rename Data Stream Manager MemTracker This change renames Data Stream Manager MemTracker to "DataStream Manager Early RPCs". Change-Id: I5bb72c28e8d660a6b78543dbc8b5b156e0e7c843 --- M be/src/runtime/krpc-data-stream-mgr.cc M tests/custom_cluster/test_krpc_mem_usage.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/9633/1 -- To view, visit http://gerrit.cloudera.org:8080/9633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5bb72c28e8d660a6b78543dbc8b5b156e0e7c843 Gerrit-Change-Number: 9633 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker
