[Impala-ASF-CR] IMPALA-6671: Change default values for flags
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17253 ) Change subject: IMPALA-6671: Change default values for flags .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7030/ -- To view, visit http://gerrit.cloudera.org:8080/17253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 Gerrit-Change-Number: 17253 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 31 Mar 2021 23:43:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6671: Change default values for flags
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17253 ) Change subject: IMPALA-6671: Change default values for flags .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8480/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 Gerrit-Change-Number: 17253 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 18:18:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6671: Change default values for flags
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17253 ) Change subject: IMPALA-6671: Change default values for flags .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8479/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 Gerrit-Change-Number: 17253 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 18:16:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6671: Change default values for flags
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17253 ) Change subject: IMPALA-6671: Change default values for flags .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7030/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 Gerrit-Change-Number: 17253 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 17:58:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6671: Change default values for flags
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17253 ) Change subject: IMPALA-6671: Change default values for flags .. IMPALA-6671: Change default values for flags This commit changes the default values of following flags which were introduced in the earlier patch for IMPALA-6671. The current default value of topic_update_tbl_max_wait_time_ms of 500ms is too low and may skip the locked tables more aggressively than needed. The new defaults were set based on analysis of a real world deployment. topic_update_tbl_max_wait_time_ms = 12 catalog_max_lock_skipped_topic_updates = 3 (or default) Testing [WIP] Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 --- M be/src/catalog/catalog-server.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/17253/2 -- To view, visit http://gerrit.cloudera.org:8080/17253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 Gerrit-Change-Number: 17253 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6671: Change default values for flags
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17253 Change subject: IMPALA-6671: Change default values for flags .. IMPALA-6671: Change default values for flags This commit changes the default values of following flags which were introduced in the earlier patch for IMPALA-6671. The current default value of topic_update_tbl_max_wait_time_ms of 500ms is too low and may skip the locked tables more aggressively than needed. The new defaults were set based on analysis of a real world deployment. topic_update_tbl_max_wait_time_ms = 12 catalog_max_lock_skipped_topic_updates = 3 (or default) Testing [WIP] Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/17253/1 -- To view, visit http://gerrit.cloudera.org:8080/17253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I79e64cdec0e6aa7b597a47851b4b5c5441ca5528 Gerrit-Change-Number: 17253 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar
